obs space with max entity id#110
Open
keraJLi wants to merge 1 commit intoepignatelli:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #109 where observations were outside the observation space. The hardcoded maximum of 8 (from n_elements=9) was insufficient to represent all entity IDs, particularly the PLAYER entity ID which has value 10.
Changes:
- Dynamically calculates the maximum entity ID from the EntityIds class at module level
- Replaces hardcoded n_elements=9 with the calculated _MAX_CATEGORICAL_VALUE (11) in categorical, categorical_first_person, and symbolic observation space definitions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109