Skip to content

Update Cert Manager Helm Values to crds.enabled=true #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

josephaw1022
Copy link

cntrl+f replace installCRDs=true to crds.enabled=true

closes #407

Copy link

netlify bot commented May 3, 2025

Deploy Preview for epinio-docs-staging ready!

Name Link
🔨 Latest commit d032712
🔍 Latest deploy log https://app.netlify.com/sites/epinio-docs-staging/deploys/681c1e502a6fd5000876117f
😎 Deploy Preview https://deploy-preview-408--epinio-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@josephaw1022
Copy link
Author

josephaw1022 commented May 3, 2025

have to update all of the versions in the docs since the helm install itself is not versioned to a specific version of cert manager. so this basically applies to all of the versions of epinio and needs to be fixed on all.

Copy link
Member

@krumware krumware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually prefer that the older docs stay as they are, and perhaps add a note about supported versions of cert-manager. Many users are still on older versions kubernetes and cert-manager (whether they should be or not), and this change may break them when they are referencing canonical URLs intentionally for older versions. Can we make this change on 1.11 and latest, and perhaps add a warning or remark on the older versions instead?

Side note: this does bring up a good opportunity to update/clarify the dependent tool versions in the documentation, for each release. (for a different issue/pr)

@josephaw1022
Copy link
Author

josephaw1022 commented May 7, 2025

one thing that I am thinking is that on 1.11 and latest, we just include a version number for cert manager too. just so a few versions later we arent in the same boat.

but yeah I can remove the changes to the other ones

@krumware

@josephaw1022
Copy link
Author

the adding of version can be done in a new issue. just want to knock this out for now and then do something like that in a different pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Upgrade to new helm value to enable crds for cert manager
2 participants