-
Notifications
You must be signed in to change notification settings - Fork 16
Update Cert Manager Helm Values to crds.enabled=true
#408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Cert Manager Helm Values to crds.enabled=true
#408
Conversation
✅ Deploy Preview for epinio-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
have to update all of the versions in the docs since the helm install itself is not versioned to a specific version of cert manager. so this basically applies to all of the versions of epinio and needs to be fixed on all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd actually prefer that the older docs stay as they are, and perhaps add a note about supported versions of cert-manager. Many users are still on older versions kubernetes and cert-manager (whether they should be or not), and this change may break them when they are referencing canonical URLs intentionally for older versions. Can we make this change on 1.11 and latest, and perhaps add a warning or remark on the older versions instead?
Side note: this does bring up a good opportunity to update/clarify the dependent tool versions in the documentation, for each release. (for a different issue/pr)
one thing that I am thinking is that on 1.11 and latest, we just include a version number for cert manager too. just so a few versions later we arent in the same boat. but yeah I can remove the changes to the other ones |
the adding of version can be done in a new issue. just want to knock this out for now and then do something like that in a different pr |
cntrl+f replace
installCRDs=true
tocrds.enabled=true
closes #407