Skip to content

Epnio 467 use pack#655

Open
psanghvi17 wants to merge 6 commits intomainfrom
Epnio-467-use-pack
Open

Epnio 467 use pack#655
psanghvi17 wants to merge 6 commits intomainfrom
Epnio-467-use-pack

Conversation

@psanghvi17
Copy link
Copy Markdown
Contributor

No description provided.

Allow choosing between lifecycle and pack builders during staging. Introduces a buildEngine flag in staging templates (defaulting to "lifecycle" for bionic and "pack" for the other template) and an image.pack configuration (registry/repository/tag) with schema validation. The staging script now branches: if BUILDENGINE="lifecycle" it runs /cnb/lifecycle/creator, otherwise it invokes the pack CLI with appropriate args (including handling --previous-image). Updates templates and values to provide the pack builder image and Docker config for pack execution.
Comment thread chart/epinio/values.yaml
pack:
registry: ""
repository: buildpacksio/pack
tag: 0.38.2
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why we are using 0.38? Latest pack version is 0.40

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

@grudra7714 grudra7714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants