Skip to content

Feat/resource views#396

Merged
grudra7714 merged 9 commits intofeat/vue3-upgradefrom
feat/resource-views
May 2, 2025
Merged

Feat/resource views#396
grudra7714 merged 9 commits intofeat/vue3-upgradefrom
feat/resource-views

Conversation

@dcharles525
Copy link
Copy Markdown
Member

@dcharles525 dcharles525 commented Apr 29, 2025

Summary

This PR creates the namespace resource and allows override of the base list component

Occurred changes and/or fixed issues

You can now create, delete, and view namespace information when clicking the "create namespace" button from the dashboard.

Technical notes summary

None

Areas or cases that should be tested

  • From the dashboard page, click "Create Namespace" and a modal should automatically appear to enter a new namespace.
  • From the side nav, when namespace is clicked, you should be brought to the namespace page
  • You should be able to delete multiple namespaces at a time
  • You should be able to click the actions dropdown to delete a single namespace
  • You should be able to filter the list component
  • The modal should tell you if the namespace name is invalid or if there was a kubernetes error (such as duplicate name).

Areas which could experience regressions

The side nav is not highlighting the correct item, this will be fixed in a separate PR>

Screenshot/Video

@dcharles525 dcharles525 changed the base branch from main to feat/vue3-upgrade April 29, 2025 21:37
@dcharles525 dcharles525 requested a review from grudra7714 April 30, 2025 17:37
Copy link
Copy Markdown
Contributor

@grudra7714 grudra7714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening up a modal already throws an error
image

Weird interaction when deleting multiple namespaces
image

Also looks like only one of the two i tried to deleted got deleted
image

Failed request reponse

{
    "errors": [
        {
            "status": 500,
            "title": "some error occurred while cleaning users: [error updating user [admin]: error updating the user secret [ruser-admin-f585ef20266ee6e88d327c03c1c1b77d4fef6340]: Operation cannot be fulfilled on secrets \"ruser-admin-f585ef20266ee6e88d327c03c1c1b77d4fef6340\": the object has been modified; please apply your changes to the latest version and try again]",
            "details": "error removing namespace [test2] from users\nServer Backtrace: some error occurred while cleaning users: [error updating user [admin]: error updating the user secret [ruser-admin-f585ef20266ee6e88d327c03c1c1b77d4fef6340]: Operation cannot be fulfilled on secrets \"ruser-admin-f585ef20266ee6e88d327c03c1c1b77d4fef6340\": the object has been modified; please apply your changes to the latest version and try again]"
        }
    ]
}

@dcharles525 dcharles525 requested a review from grudra7714 May 2, 2025 13:58
Copy link
Copy Markdown
Contributor

@grudra7714 grudra7714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, delete modal will be handled by a seperate pr

@grudra7714 grudra7714 merged commit f4cf18e into feat/vue3-upgrade May 2, 2025
0 of 2 checks passed
@grudra7714 grudra7714 deleted the feat/resource-views branch May 2, 2025 17:13
@krumware krumware added the kind/enhancement New feature or request label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants