Skip to content

Feat/epinio 523 524 services catalog#554

Open
johnlcos wants to merge 3 commits into1.14.0from
feat/EPINIO-523-524__services_catalog
Open

Feat/epinio 523 524 services catalog#554
johnlcos wants to merge 3 commits into1.14.0from
feat/EPINIO-523-524__services_catalog

Conversation

@johnlcos
Copy link
Copy Markdown
Collaborator

@johnlcos johnlcos commented Apr 1, 2026

PR Checklist

  • Linting Test is passing
  • Code is well documented
  • If applicable, a PR in the epinio/docs repository has been opened

Summary

Fixes #

Occurred changes and/or fixed issues

  • Updates the services catalog and catalog service details page to utilize trailhand components.

Technical notes summary

  • The service catalog page primarily involved swapping out a rancher shell component for the trailhand card components.
  • The catalog service detail page was setup within the Rancher shell using the ResourceDetail component. Because the way the project is setup within the shell, the best fix ended up being to hide the header for the ResourceDetail component and import the on from the ResourceList and use that. This way we do not have to mess with the structure of resources.

Areas or cases that should be tested

  • Viewing, creating, editing and deleting service through the catalog page.

Areas which could experience regressions

Screenshot/Video

image image

@johnlcos johnlcos requested a review from Hannahbird April 1, 2026 19:42
Copy link
Copy Markdown
Contributor

@Hannahbird Hannahbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharles525 dcharles525 self-requested a review April 13, 2026 18:30
Copy link
Copy Markdown
Member

@dcharles525 dcharles525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing here, noticed that the images are hardcoded for each service, they normally come from here . We should update them there (just web link them) rather than hardcoding them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants