Issue #536: Setting the threshold to Inf message#537
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
+ Coverage 94.38% 94.41% +0.02%
==========================================
Files 17 17
Lines 837 841 +4
==========================================
+ Hits 790 794 +4
Misses 47 47 ☔ View full report in Codecov by Sentry. |
seabbs
requested changes
Feb 19, 2025
Contributor
seabbs
left a comment
There was a problem hiding this comment.
I think essentially this just makes the progress message overly verbose. See the specific comments for suggestions.
Collaborator
Author
|
Have made more concise. Feel free to edit / close if preferred |
Collaborator
Author
|
Shall we merge or close this @seabbs? |
Collaborator
Author
|
Closing for now. |
Contributor
|
sorry missed the question here. I will circle back to this next time I do a block of epidist dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a draft PR to close #536.
Looking at the linting errors, I think they're unrelated to changes made here?
Checklist