Skip to content

Issue #554: Model vignette fixes#555

Merged
seabbs merged 2 commits intomainfrom
model-vignette-fixes
Mar 14, 2025
Merged

Issue #554: Model vignette fixes#555
seabbs merged 2 commits intomainfrom
model-vignette-fixes

Conversation

@athowes
Copy link
Copy Markdown
Collaborator

@athowes athowes commented Mar 13, 2025

Description

This PR closes #554. Self-explained.

Pre-commit is currently failing everywhere. Considering new issue / fix.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (e657990) to head (dbb874a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files          17       17           
  Lines        1015     1015           
=======================================
  Hits          971      971           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@athowes athowes requested a review from seabbs March 13, 2025 14:00
@athowes athowes marked this pull request as ready for review March 14, 2025 10:41
Copy link
Copy Markdown
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ty

@seabbs seabbs merged commit 7dc6757 into main Mar 14, 2025
10 of 11 checks passed
@seabbs seabbs deleted the model-vignette-fixes branch March 14, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model vignette display issues

2 participants