Fixing compilation errors, adding README - #1
Open
meatbody wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the basic command line
g++ artin_code.cpp, I received the following errors:I attempted to compile this file with
g++on macOS 15.0 (24A335).g++returned the following version information.This pull request attempts to fix the above errors. It removes the initial
artin_codeline at the beginning of the file, which I believe is possibly just a syntax error? It comments out the seemingly-unusedpiiandviitypedefs, as they were producing missing template argument errors above. It adds template arguments to theunordered_mapf_vals, mapping fromlong longtolong double. I'm not certain these are the correct types for this map, so reviewers should check this with special care. Finally, it adds a README explaining steps for compiling and running the program.After these modifications, I was able to compile and run the program successfully. I confirmed the program's execution up to the time-consuming main loop, but didn't get to see the main loop complete and produce the final answer even after running for a couple hours. A reviewer should confirm that the program still completes successfully and produces the correct answer after these modifications.