Conversation
cb3b51f to
fb2e808
Compare
bfc8143 to
a84cc0d
Compare
fa5cfb3 to
c421232
Compare
vbar
reviewed
Sep 19, 2025
vbar
reviewed
Sep 19, 2025
vbar
approved these changes
Sep 19, 2025
Member
Author
|
Still fixing an issue with the fake proposals DB getting into a locked state... |
vbar
reviewed
Sep 19, 2025
1a8cdd4 to
56af494
Compare
t00ts
approved these changes
Sep 22, 2025
Member
Author
|
Now that I'm more sure I fixed fake proposal creation I have discovered a bug which I'm fixing rn: #3019 |
…l if CONSENSUS_TEST_DUMP_CHILD_LOGS_ON_FAIL is set
…read on drop in concurrent storage adapter
da631bb to
0893a1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: consensus smoke test flakiness
--consensus.enable=true.H>10, due to system contract0x1and we always want to generate valid proposals)./tmp/...), so if the env variablePATHFINDER_CONSENSUS_TEST_DUMP_CHILD_LOGS_ON_FAILis set all of those log files are dumped to the parent process descriptors should the test fail. We cannot useStdio::piped()because the logs from all child processes would get mixed up and thus become unintelligible.