fix(rpc/pending): validate pre-confirmed data before use#3022
Merged
Conversation
vbar
approved these changes
Sep 24, 2025
There seem to be occasional inconsistencies in the pre-confirmed data provided by the feeder gateway. Contrary to what the documentation says, the executed transactions are not always a prefix of all transactions in the block. This breaks our assumptions on how to split the transactions into pre-confirmed and candidate sets. To work around this, we now consider all transactions which have a matching receipt as pre-confirmed, and the rest as candidates, irrespective of the order in which they appear in the original pre-confirmed block.
kkovaacs
force-pushed
the
krisztian/work-around-pre-confirmed-data-inconsistency
branch
from
6b13be4 to
0c057d8
Compare
kkovaacs
deleted the
krisztian/work-around-pre-confirmed-data-inconsistency
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seem to be occasional inconsistencies in the pre-confirmed data provided by the feeder gateway.
Contrary to what the documentation says, the executed transactions are not always a prefix of all transactions in the block. This breaks our assumptions on how to split the transactions into pre-confirmed and candidate sets.
To work around this, we now consider all transactions which have a matching receipt as pre-confirmed, and the rest as candidates, irrespective of the order in which they appear in the original pre-confirmed block.
Closes #3018