Conversation
CHr15F0x
commented
Mar 11, 2026
0e2a822 to
5b39520
Compare
910f36d to
b71decc
Compare
…transactions for reverts
b71decc to
c367a1c
Compare
zvolin
reviewed
Mar 12, 2026
Contributor
zvolin
left a comment
There was a problem hiding this comment.
some first pass, but haven't read through deeply yet 🙈
kkovaacs
reviewed
Mar 13, 2026
Contributor
kkovaacs
left a comment
There was a problem hiding this comment.
Looks solid other than the typos / suggested renames.
7544b27 to
d0f87f5
Compare
kkovaacs
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that our proposal processing logic did not store successfully declared classes. Which then resulted in deployments failing. This was not covered by the integration tests, which passed happily.
List of changes: