-
Notifications
You must be signed in to change notification settings - Fork 19
Added Landmark Location #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Added Landmark Location #1028
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
eb2dbb6
added: landmark and landmark location to database
SteveJonesDev 906f46b
updated: test
SteveJonesDev 5baaf70
added: support for conditional landmark tags and roles in landmark de…
SteveJonesDev fb4d1e7
added: include landmark data in AJAX response and updated layout for …
SteveJonesDev 2fd3252
added: enhance landmark handling by including landmark selector and i…
SteveJonesDev 4c02072
updated: to prevent variable hoisting
SteveJonesDev f21e8f3
added: escape CSS class names to prevent injection issues
SteveJonesDev 80c0643
added: adjust scrolling behavior to include a 75px offset when naviga…
SteveJonesDev 2f2ada3
added: set max-width and box-sizing for selected highlight elements
SteveJonesDev 065b064
updated: add nullable type hints for landmark and landmark_selector p…
SteveJonesDev de8ca07
updated: use null coalescing operator for landmark and landmark_selec…
SteveJonesDev 0510deb
updated: capitalize landmark names in aria labels and links for impro…
SteveJonesDev fed9312
updated: adjust z-index value for highlight tooltip to prevent overla…
SteveJonesDev bbd55f1
Merge branch 'develop' into steve/try/landmark-location
pattonwebz 8a9e296
Merge branch 'steve/try/landmark-location' of https://github.com/equa…
SteveJonesDev 205a64c
updated: revert database version to 1.0.4 in accessibility checker pl…
SteveJonesDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding scalar type hints to the
$landmarkand$landmark_selectorparameters for better type safety and code clarity. Use?stringsince they are nullable.