Release v1.32.0 - #1236
Conversation
[Backport] Release v1.31.1
instawp api doesn't actually support pushing a file directly by curl, the zip needs to be publicly accessible - presumably because it uses wp-cli to install
Enhance the deployment workflow to conditionally retrieve the plugin zip file from release assets when triggered by a release event.
This means it will output on the preview for the command rather than just in the --help for the command.
updated: sanitize and unslash review action before updating option for review notice
Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
…ding image overrides Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
…rphaned-cleanup-command-have-a-synopis Add synopsis to the cleanup-orphaned-issues command
…ing-heading-order added: 'heading-order' to standardRuleIdsArray
Fix element sizing issues in Frontend Highlighter by removing problematic CSS styles
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment |
There was a problem hiding this comment.
Summary of Changes
Hello @pattonwebz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request prepares for the v1.32.0 release of the Accessibility Checker plugin. It includes important updates such as improved sanitization for review notices, an expanded set of accessibility rules to check for, and a fix for frontend highlighter display issues. Additionally, it enhances the WP-CLI command for cleaning up orphaned issues by better defining its arguments.
Highlights
- Version Update: The plugin version has been updated to
1.32.0across relevant files, signifying a new release. - Security/Sanitization Improvement: Enhanced the handling of review notice actions by adding
wp_unslash()for better security and data integrity. - Accessibility Rule Addition: Included 'heading-order' in the standard accessibility rule set, expanding the plugin's auditing capabilities.
- WP-CLI Command Enhancement: The
cleanup-orphaned-issuesWP-CLI command now properly defines its arguments using asynopsisstructure, improving its discoverability and usage. - Frontend UI Fix: Resolved frontend highlighter element sizing issues by removing conflicting CSS properties.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Pull Request Overview
This release (v1.32.0) includes several maintenance improvements and bug fixes for the Accessibility Checker plugin. The PR updates version numbers across files and implements three key functional changes.
Key changes:
- Enhanced WPCLI command structure with proper synopsis format for better WordPress CLI integration
- Fixed frontend highlighter CSS sizing issues that were causing display problems
- Improved security by adding proper sanitization and unslashing for review notice handling
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| accessibility-checker.php | Version bump to 1.32.0 in plugin header and constant |
| package.json | Version update to 1.32.0 |
| readme.txt | Stable tag updated to 1.32.0 |
| includes/classes/WPCLI/Command/CleanupOrphanedIssues.php | Restructured command arguments to use proper WP-CLI synopsis format |
| tests/phpunit/includes/classes/WPCLI/Commands/CleanupOrphanedIssuesTest.php | Updated tests to match new synopsis-based argument structure |
| admin/class-admin-notices.php | Added wp_unslash() to review action sanitization |
| src/pageScanner/config/rules.js | Added 'heading-order' rule to standard rules array |
| src/frontendHighlighterApp/sass/app.scss | Removed problematic CSS sizing styles |
| .github/workflows/deploy-on-release-to-woocommerce.yml | New GitHub workflow for WooCommerce deployment |
| .github/workflows/deploy-on-release-to-instawp.yml | New GitHub workflow for InstaWP deployment |
There was a problem hiding this comment.
Code Review
This pull request prepares for the v1.32.0 release by bumping version numbers across several files. It also includes a few fixes and improvements: sanitization of user input in an AJAX handler, updating a WP-CLI command to use the modern synopsis format for arguments, adding the heading-order accessibility rule, and fixing a CSS issue in the frontend highlighter.
My review found one potential issue in admin/class-admin-notices.php where the return value of update_option() is not handled correctly, which could lead to incorrect error messages being sent to the user. I've provided a suggestion to fix this.
Overall, the changes are good and align with the release goals.
Changelog:
Steve Jones (2):
William Patton (3):