Release v1.33.0 - #1242
Conversation
Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
…ires at least" calculation Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
- Changed logic from "3 back" to "2 back" to support last 3 versions (6.8 → 6.7 → 6.6) - Updated regex to handle actual JSON format with patch versions (6.8.2 → 6.8) - Updated error messages and comments to reflect new logic Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
[Backport] Release v1.32.0
This allows other plugins to add commands on init but at earlier priority
This change introduces a `get_shortname` method to several command classes, providing a concise identifier for each command. [PRO-300]
[PRO-300]
…dc-4ea0-bba2-0ba2430e16ff Add scripted 'requires at least' to release script
…cence-activation-deactivation-status-cli-command Make commands bootstrap later at `init` and add support for shorthand names on commands
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Comment |
Summary of ChangesHello @pattonwebz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on preparing the plugin for its Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull Request Overview
This release PR bumps the plugin version from 1.32.0 to 1.33.0 and includes infrastructure improvements for WP-CLI commands and automated WordPress version requirement updates.
- Adds automated WordPress version requirement calculation to the release script
- Implements shorthand command names for WP-CLI commands (e.g.,
edac get-statsinstead ofaccessibility-checker get-stats) - Modifies WP-CLI command registration to occur at the
inithook instead of during plugin construction
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/prep_release.sh | Adds comprehensive WordPress version requirement automation that fetches versions from WordPress API and calculates minimum required version |
| readme.txt | Updates stable tag version from 1.32.0 to 1.33.0 |
| package.json | Updates package version from 1.32.0 to 1.33.0 |
| includes/classes/class-plugin.php | Moves WP-CLI command registration to init hook with anonymous function wrapper |
| includes/classes/WPCLI/Command/*.php | Adds get_shortname() method to all command classes for shorthand CLI usage |
| includes/classes/WPCLI/BootstrapCLI.php | Adds logic to register shorthand command names when available |
| accessibility-checker.php | Updates plugin version from 1.32.0 to 1.33.0 in header and constant |
There was a problem hiding this comment.
Code Review
This pull request introduces version 1.33.0. The main changes include adding shorthand aliases for WP-CLI commands, deferring their registration to the init hook for better stability, and enhancing the release script to automatically update the Requires at least WordPress version. My review focuses on improving the robustness of the release script and a small efficiency gain in the WP-CLI command registration. The changes are generally good and improve the developer experience and release process.
Steve Jones (1):
William Patton (2):
initand add support for shorthand names on commands