Skip to content

Updated: passed test percentage logic to include scannable post types and handle cases with no posts scanned. #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveJonesDev merged 2 commits into from
Dec 16, 2025
Merged

Updated: passed test percentage logic to include scannable post types and handle cases with no posts scanned. #1291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c81cb15
Updated: passed test percentage logic to include scannable post types…
SteveJonesDev Dec 2, 2025
c15a0e4
Merge branch 'develop' into steve/no-issue/passed-test-percentage-logic
pattonwebz Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions admin/class-scans-stats.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,9 @@ function ( $item ) {
$rule_query = new Issues_Query(
[
'rule_slugs' => [ $rule_slug ],
'post_types' => Settings::get_scannable_post_types(),

@gemini-code-assist gemini-code-assist Bot Dec 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The function Settings::get_scannable_post_types() is called multiple times within the summary method (here inside a loop, and on lines 199, 206, 216, 227, 240, and 251). This can be inefficient as the function may perform database queries. To improve performance, consider calling it once at the start of the summary method, storing the result in a variable, and reusing that variable throughout the method.

@pattonwebz pattonwebz Dec 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a nice change here but it's somewhat out of scope of the actual thing being fixed here.

The method does make a query to get an option and then processes it but the option is autoloaded so only retrieved once from database then from memory on subsequent calls.

],
1,
Issues_Query::FLAG_INCLUDE_ALL_POST_TYPES
1
);

if ( $rule_query->count() ) {
Expand All @@ -195,8 +195,9 @@ function ( $item ) {
}
$data['rules_passed'] = $this->rule_count - $data['rules_failed'];

$data['passed_percentage'] = 100;
if ( $data['posts_scanned'] > 0 && $tests_count > 0 ) {
$data['passed_percentage'] = 'N/A';
$scannable_post_types = Settings::get_scannable_post_types();
if ( ! empty( $scannable_post_types ) && $data['posts_scanned'] > 0 && $tests_count > 0 ) {
$data['passed_percentage'] = round( ( $data['rules_passed'] / $this->rule_count ) * 100, 2 );
}

Expand Down
Loading