Release v1.36.0 - #1316
Conversation
… and handle cases with no posts scanned.
[Backport] Release v1.35.0
…o_welcome() calls
…date corresponding test
…Activation_Redirect class
…d in Activation_Redirect class
…Authors and above to access the welcome page
…ecks in ActivationRedirectTest
… in link validation tests
…sion-to-improper-use-of-link-rule-if-rolemenuitem Add: exclusion for role="menuitem" with aria-expanded in link validation
…ty-alternative-text-new-keyword Add: "an image" to invalid alt text checks and corresponding tests
…est-percentage-logic Updated: passed test percentage logic to include scannable post types and handle cases with no posts scanned.
…_redirect_to_welcome() method
…n-redirect Added: activation redirect to welcome page and add corresponding tests
The 3rd paramiter was set to false meaning it would never echo the selected value even when the current item was the selected one in the database. [PRO-487]
…o-is-active-the-scan-speed-setting-doesnt-update Fix selected scan speed option value being reflected
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Summary of ChangesHello @pattonwebz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a significant upgrade to the plugin's security infrastructure and user experience. It introduces a robust JWT key rotation system, combining proactive daily verification with reactive fallback mechanisms to ensure uninterrupted service and secure API communication. Additionally, it refines accessibility checks by addressing specific link and image alt text patterns, and enhances the user onboarding process with an activation redirect. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces version 1.36.0, which includes several valuable features and fixes. The changes are well-implemented and include corresponding tests, which is great. Key additions include a welcome page redirect on plugin activation, improved accessibility checks for links and image alt text, and more robust logic for calculating scan statistics. The fix for the scan speed option is also correctly implemented. The new documentation for JWT Key Rotation is comprehensive, though a small clarification could improve it. Overall, this is a high-quality release.
| 2. Have issuer rotate its private key | ||
| 3. Wait for daily cron to run (or trigger manually) | ||
| 4. Verify that `edac_jwt_public_key` option was updated with new key | ||
| 5. Make REST API call with old JWT - should still work because key was refreshed |
There was a problem hiding this comment.
The description for this test step is a bit ambiguous. The term "old JWT" could be misinterpreted. To improve clarity, I suggest specifying that the JWT should be signed with the new issuer key to confirm that the proactive key refresh was successful.
| 5. Make REST API call with old JWT - should still work because key was refreshed | |
| 5. Make REST API call with a JWT signed with the new issuer key - it should work seamlessly because the public key was proactively refreshed |
There was a problem hiding this comment.
Pull request overview
This release (v1.36.0) introduces several enhancements to accessibility checking, improves user onboarding, and fixes a UI bug. Key changes include:
- New activation redirect to welcome page for better onboarding
- Enhanced link validation to support expandable menu items with
role="menuitem"andaria-expanded - Expanded invalid alt text detection to include "an image" patterns
- Fixed scan speed dropdown selection display issue
- Improved passed test percentage logic to handle edge cases with no scannable post types
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| accessibility-checker.php | Updated plugin version to 1.36.0 |
| package.json | Updated package version to 1.36.0 |
| readme.txt | Updated stable tag to 1.36.0 |
| admin/class-activation-redirect.php | New class to handle redirect to welcome page after plugin activation with proper capability and context checks |
| admin/class-admin.php | Integrated Activation_Redirect class initialization |
| includes/activation.php | Set transient to trigger welcome page redirect after activation |
| tests/phpunit/Admin/ActivationRedirectTest.php | Comprehensive test coverage for activation redirect functionality |
| src/pageScanner/checks/link-has-valid-href-or-role.js | Added support for menuitem role with aria-expanded attribute, refactored for better code efficiency |
| tests/jest/rules/linkImproper.test.js | Added test cases for menuitem role with aria-expanded validation |
| src/pageScanner/checks/img-alt-invalid-check.js | Added "an image" to invalid alt text patterns |
| tests/jest/rules/imgAltInvalid.test.js | Added test cases for "an image" alt text validation |
| includes/options-page.php | Fixed selected() function call by removing incorrect false parameter |
| admin/class-scans-stats.php | Enhanced passed percentage logic to respect scannable post types and return 'N/A' when appropriate |
| JWT_KEY_ROTATION_IMPLEMENTATION.md | Documentation file for JWT key rotation (appears unrelated to this release) |
|
@pattonwebz I've opened a new pull request, #1317, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
Fix @SInCE version tags in Activation_Redirect class
…n-redirect Fix: Update namespace references for Activation_Redirect class in admin files
Changelog:
Steve Jones (4):
William Patton (2):