Skip to content

Add versioning to scanner bundle URL for frontend scans #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pattonwebz merged 3 commits into from
May 12, 2026
Merged

Add versioning to scanner bundle URL for frontend scans #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a861e10
Add versioning to scanner bundle URL
pattonwebz May 5, 2026
00dd795
escape the scanner bundle url and use add_query_arg to append ver for…
pattonwebz May 5, 2026
144bd77
Add PHPUnit test verifying scannerBundleUrl includes version query st…
Copilot May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion includes/classes/class-enqueue-frontend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public static function maybe_enqueue_frontend_highlighter() {
'appCssUrl' => EDAC_PLUGIN_URL . 'build/css/frontendHighlighterApp.css?ver=' . EDAC_VERSION,
'widgetPosition' => get_option( 'edac_frontend_highlighter_position', 'right' ),
'editorLink' => get_edit_post_link( $post_id ),
'scannerBundleUrl' => plugin_dir_url( EDAC_PLUGIN_FILE ) . 'build/pageScanner.bundle.js',
'scannerBundleUrl' => esc_url_raw( add_query_arg( 'ver', EDAC_VERSION, plugin_dir_url( __FILE__ ) . 'build/pageScanner.bundle.js' ) ),
'adminThemeColor' => self::get_admin_theme_color(),
]
);
Expand Down
22 changes: 22 additions & 0 deletions tests/phpunit/includes/classes/EnqueueFrontendTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,28 @@ protected function tearDown(): void {
parent::tearDown();
}

/**
* Ensure the localized scannerBundleUrl includes the plugin version as a query string parameter.
*/
public function testScannerBundleUrlIncludesVersionQueryString(): void {
$admin_id = $this->factory()->user->create( [ 'role' => 'administrator' ] );
wp_set_current_user( $admin_id );

$created_post = $this->factory()->post->create_and_get( [ 'post_type' => 'post' ] );

global $post;
$post = $created_post;

Enqueue_Frontend::maybe_enqueue_frontend_highlighter();

global $wp_scripts;
$localized_data = $wp_scripts->get_data( 'edac-frontend-highlighter-app', 'data' );

$this->assertNotEmpty( $localized_data );
$this->assertStringContainsString( 'scannerBundleUrl', $localized_data );
$this->assertStringContainsString( 'ver=' . EDAC_VERSION, $localized_data );
}

/**
* Ensure the highlighter uses the filtered post ID when determining scannable post types.
*/
Expand Down
Loading