Skip to content

Add versioning to scanner bundle URL for frontend scans #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pattonwebz merged 3 commits into from
May 12, 2026
Merged

Add versioning to scanner bundle URL for frontend scans #1682

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a861e10
Add versioning to scanner bundle URL
pattonwebz May 5, 2026
00dd795
escape the scanner bundle url and use add_query_arg to append ver for…
pattonwebz May 5, 2026
144bd77
Add PHPUnit test verifying scannerBundleUrl includes version query st…
Copilot May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion includes/classes/class-enqueue-frontend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public static function maybe_enqueue_frontend_highlighter() {
'appCssUrl' => EDAC_PLUGIN_URL . 'build/css/frontendHighlighterApp.css?ver=' . EDAC_VERSION,
'widgetPosition' => get_option( 'edac_frontend_highlighter_position', 'right' ),
'editorLink' => get_edit_post_link( $post_id ),
'scannerBundleUrl' => plugin_dir_url( EDAC_PLUGIN_FILE ) . 'build/pageScanner.bundle.js',
'scannerBundleUrl' => plugin_dir_url( EDAC_PLUGIN_FILE ) . 'build/pageScanner.bundle.js?ver=' . EDAC_VERSION,
Comment thread
pattonwebz marked this conversation as resolved.
Outdated

@pattonwebz pattonwebz May 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copilot AI May 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added testScannerBundleUrlIncludesVersionQueryString to EnqueueFrontendTest in commit 144bd77. It enqueues the frontend highlighter as an admin, then asserts the localized edacFrontendHighlighterApp data contains both scannerBundleUrl and ver=EDAC_VERSION.

Comment thread
pattonwebz marked this conversation as resolved.
Outdated
'adminThemeColor' => self::get_admin_theme_color(),
]
);
Expand Down
Loading