[Backport] Release v1.41.0 - #1695
Merged
Merged
Conversation
Release v1.40.0
Elementor (and other builders) use a visually-hidden pattern — clip, 1px dimensions, overflow hidden — to provide accessible labels for icon-only elements. These labels have no meaningful font size to enforce, so the text_size_too_small check was producing a false positive. Adds isScreenReaderOnly() to helpers, which walks the element and its ancestors checking for the sr-only clip pattern, and gates the check early when matched. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Avoids ancestor style walks on nodes that would return false before reaching font-size evaluation anyway. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
clip: rect(0,0,0,0) only clips visually on position:absolute/fixed elements. clipPath:inset(50%) has no such restriction and is left unguarded. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Covers passing cases (adequate font size, empty content, non-leaf containers, sr-only clip patterns) and failing cases (text at or below 10px threshold). Includes a regression test for the Elementor social icon sr-only false positive. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
'should pass...' with shouldPass: false was misleading. Renamed to 'should fail...' and moved into the failing cases section. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
clip/clip-path checks alone miss Elementor's .elementor-screen-only class, which uses position:absolute + width:1px + height:1px + overflow:hidden without relying on clip values. Adds that combination as a third detection path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Elementor sets font-size: 0 on icon widget containers to eliminate inline-block spacing gaps. Spans inside (including sr-only labels) inherit this value and were being falsely flagged. font-size: 0 means text is not rendering — it is not the same concern as visible text that is too small to read. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-icon-screen-reader-text-or-something-false Fix false positive: skip screen-reader-only elements in text_size_too_small check
Agent-Logs-Url: https://github.com/equalizedigital/accessibility-checker/sessions/19043fe8-80b7-4e06-99ad-8118fe23260f Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
…lity-checker into release/1.41.0
…lity-checker into release/1.41.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Backport
This is an automatic backport of PR #1693 by @pattonwebz to the
developbranch.Original PR Details:
Steve Jones (3):
William Patton (6):
role="heading"elements as possible headingsThis PR was created automatically when #1693 was merged into
main.