-
Notifications
You must be signed in to change notification settings - Fork 19
Release v1.44.0 #1781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release v1.44.0 #1781
Changes from 83 commits
Commits
Show all changes
128 commits
Select commit
Hold shift + click to select a range
743de69
feat: Add axe rule to detect naked links
google-labs-jules[bot] 6a1e464
Move the rule to a 'none' type for fails
pattonwebz 964f824
Rename the rule to use an underscore matching out existing name pattern
pattonwebz ac8d57d
Loosen the rule expectation in the test
pattonwebz 0e6cfa2
Rename the naked link rule, check and test files
pattonwebz baf60c8
Fix lint issues
pattonwebz 717e855
Add a rule definition for the new Naked Link rule
pattonwebz 3c5894c
Correct file reference for new rules
pattonwebz c20be43
Fix rule name in test
pattonwebz 495756b
Merge branch 'develop' into feature/naked-link-rule
pattonwebz b4ea152
Update the names of the new rule and check to use dashes instead of c…
pattonwebz 8271006
Use name that starts with `link` for the rule to match other link che…
pattonwebz 4d6d0ea
Add the php rule definition for Link Naked rule
pattonwebz cb23f90
Update tests to point to the updated file names
pattonwebz f578564
Make sure the list of rule classes stay in alphabetical order
pattonwebz 1cbc688
Make sure that mailto and tel links will fail if they are _mostly_ naked
pattonwebz c1009c8
Make the naked link rule be an error rather than a warning
pattonwebz 6ef94b4
Update the test cases to cover more items and fix test file name
pattonwebz 2f31b3b
Refactor the test to cover all the new test cases added with pass/fai…
pattonwebz cd20298
Add more test cases for naked links since the rule ended up much more…
pattonwebz 29ec979
Guard EDAC_KEY_VALID usage in options page
SteveJonesDev 77392c7
Handle missing EDAC key flag
SteveJonesDev 1f65eaf
Export the first set of components to be shared with other add-ons
pattonwebz 63b95ec
Add a few more components and helpers to the list of shared components
pattonwebz 9efe75d
Setup for jest tests on some of the react components we will export f…
pattonwebz 9f63cd3
Add some jest tests for components that are being exported
pattonwebz 42a3f2b
Fix some old lint issues in a few test files
pattonwebz 1911ed0
PRO-540: Update how_to_fix language to remove references to the Ignor…
SteveJonesDev 2db1620
Update dashboard link in Email Reports to point to license keys page
SteveJonesDev 43299ab
Update 'Reports Enabled' message to clarify email recipient for free …
SteveJonesDev 8dc65ad
Add some test setup needed for react act to test the sidebar components
pattonwebz f023d7d
Merge pull request #1728 from equalizedigital/steve/pro-778-email-rep…
SteveJonesDev f5d104a
Merge pull request #1731 from equalizedigital/release/1.43.0
SteveJonesDev cb61239
Remove unimplemented Pro upsell from Reports Enabled message
SteveJonesDev 1827bfe
Merge pull request #1729 from equalizedigital/steve/pro-780-email-rep…
SteveJonesDev 714cbb3
Apply Amber's feedback to the Link Text is URL rule
SteveJonesDev e36c993
Fix JS lint error: restore straight quotes on Don't test case
SteveJonesDev 7e4daf8
Update composer.lock from develop to fix CVE-2026-24765
SteveJonesDev 6ee6e87
Update composer.lock from develop to fix CVE-2026-24765
SteveJonesDev d650aad
docs: regenerate hooks docs
github-actions[bot] a0d53e4
Merge pull request #1734 from equalizedigital/automation/regenerate-h…
SteveJonesDev c212b90
Merge branch 'develop' into feature/naked-link-rule
SteveJonesDev f1157cc
fix: resolve merge conflict in composer.lock and update dependencies
SteveJonesDev b574177
feat: export severity and rule type helpers from shared components
pattonwebz fa29532
Udpated: naked link file names and slugs and normalized tags to use a…
SteveJonesDev bbaa34e
feat: add internationalization support for link text checks
SteveJonesDev 908597c
Refactor EDAC_KEY_VALID condition for clarity
SteveJonesDev 9fb6293
Merge remote-tracking branch 'origin/develop' into codex/run-automate…
SteveJonesDev aa68255
feat: add sharedComponents webpack entry with window global export
pattonwebz c7149b0
Fix serialization error in separate-process test
SteveJonesDev c9be6ac
fix: import getSeverityBadgeProps from badgeHelpers not severityHelpers
pattonwebz 2768868
Merge pull request #1402 from equalizedigital/codex/fix-edac-key-vali…
SteveJonesDev 31f7eff
Merge pull request #1407 from equalizedigital/codex/run-automated-bug…
SteveJonesDev 98608d3
Merge pull request #1724 from equalizedigital/steve/pro-540-update-ho…
SteveJonesDev 6faec4a
feat: export DismissPanel from sharedComponents
pattonwebz 709ff92
Remove dead is_numeric check on policy page option
SteveJonesDev 0f29712
Merge pull request #1735 from equalizedigital/steve/no-issue/remove-d…
SteveJonesDev 79b9d60
refactor: extract FixCard as shared component and export from sharedC…
pattonwebz c78b09e
refactor: pull DismissPanel styles up to root scope
pattonwebz 0ec7835
fix: correct split button alignment to center in dismiss panel base s…
pattonwebz 2245235
revert: restore align-items: flex-end on split button
pattonwebz 0492b7e
Add a system generated rest api url to localized data for frontend hi…
pattonwebz 03ecb65
Use the system generated rest url for the frontend highlighter scan s…
pattonwebz e47899f
Pass the fixes url through rest_url to ensure it is correct on subsit…
pattonwebz 87c49d2
Use an updated rest url for fixes to make sure it works on multisite …
pattonwebz 08d4a7e
Add unit tests to cover and verify the changes to the rest api urls a…
pattonwebz ce8674d
fix: guard against undefined REST URLs and use window. prefix consist…
pattonwebz f713376
docs: regenerate hooks docs
github-actions[bot] cb1bb42
Merge pull request #1738 from equalizedigital/automation/regenerate-h…
pattonwebz df92b7c
docs: regenerate hooks docs
github-actions[bot] e71d0e4
Create Accessibility Issue template structure
amberhinds e9749a5
Fix indentation on WCAG Success Criterion dropdown
amberhinds 3a89ca4
PRO-960: Restore global dismiss/unignore inline in DismissPanel
pattonwebz 077df81
PRO-960: Add forceGlobal prop to DismissPanel
pattonwebz bd4b724
PRO-960: Batch undismiss when issue was globally dismissed
pattonwebz eef4a2d
PRO-960: Remove (all pages) from Dismiss Globally dropdown label
pattonwebz d5d2e65
PRO-960: Address review comments on DismissPanel and api.js
pattonwebz 54540e7
Merge pull request #1746 from equalizedigital/william/pro-960-dismiss…
pattonwebz 1fdba55
Initial plan
Copilot 8f82063
chore: initial plan - add wp-block-separator exclusion to aria-hidden…
Copilot 378b315
fix: exclude wp-block-separator from aria-hidden review issues
Copilot 744862c
Address PR review: make three fields optional and update version plac…
pattonwebz 87d829b
Potential fix for pull request finding
pattonwebz a0290cc
Merge pull request #1744 from equalizedigital/amberhinds-github-issue…
pattonwebz fe06eb1
PRO-959: Add edac_get_landmark_types() as single source of truth for …
SteveJonesDev df8b356
PRO-959: Thread landmarkTypes into frontend highlighter scanner context
pattonwebz 226a5c5
PRO-959: Address code review — filter hook, i18n labels, Array.isArra…
pattonwebz cfc2181
PRO-959: Guard inner keys in edac_get_landmark_filter_options against…
pattonwebz 2929343
PRO-959: Fix @since tags on new PHP helper functions (1.44.0)
pattonwebz 04ce817
Merge pull request #1760 from equalizedigital/william/pro-959-landmar…
pattonwebz fb95d52
PRO-972: Extract CodeMirrorViewer to own file and export from sharedC…
pattonwebz 8ba427a
PRO-972/PRO-979: Dual-scope CodeMirrorViewer and IssueImage CSS
pattonwebz 2495824
PRO-972/PRO-979: Add edacp-ie-dismiss-modal to CodeMirrorViewer CSS s…
pattonwebz beeb544
fix: null editorRef after toTextArea() to prevent stale ref on remount
pattonwebz e778a6f
Initial plan
Copilot 8040c46
Initial plan
Copilot d0b1419
Fix new window warning aria-label for links with images and text
Copilot d98e25a
Initial plan
Copilot f7f429f
Initial plan: Don't flag empty paragraphs with aria-live
Copilot 4880aab
Rules: Don't flag empty paragraph on paragraphs with aria-live
Copilot af5d921
Merge pull request #1743 from equalizedigital/automation/regenerate-h…
SteveJonesDev 42de267
fix: address CodeRabbit review comments on PR #1733
pattonwebz a323e97
Gating global dismiss for free users [PRO-823]
pattonwebz aaaa51b
Stubbing DismissPanel Jest mocks [PRO-823]
pattonwebz 8e70799
Merge branch 'develop' into william/pro-823-setup-component-exports-f…
pattonwebz 6789814
Merge pull request #1733 from equalizedigital/william/pro-823-setup-c…
pattonwebz 56a7fbc
Merge pull request #1737 from equalizedigital/william/no-issue/fix-su…
pattonwebz 5614631
Merge pull request #1774 from equalizedigital/copilot/fix-empty-parag…
pattonwebz 1b059ba
Merge pull request #1773 from equalizedigital/copilot/fix-new-window-…
pattonwebz e2f5329
Merge pull request #1751 from equalizedigital/copilot/enhance-aria-hi…
pattonwebz 1be7ea8
Bump version * Version: 1.43.0 -> 1.44.0
pattonwebz 266df9e
Fix: address Gemini code review feedback on release/1.44.0
pattonwebz b4eda25
Merge pull request #1012 from equalizedigital/feature/naked-link-rule
pattonwebz 86fe8e8
Fix: correct 'contentinfo' landmark label from 'Content Info' to 'Con…
pattonwebz afabcba
Merge branch 'release/1.44.0' of github.com:equalizedigital/accessibi…
pattonwebz 4ee77c5
PRO-1039: Replace remaining 'Ignore' terminology with 'Dismiss'
SteveJonesDev db858b0
Replace 'Ingore' with 'Dismiss' in LinkTextIsUrlRule strings
pattonwebz e068cef
Fix grammar in dismiss terminology per code review
SteveJonesDev f736ae9
Update some test names to be more descriptive of what they are testing
pattonwebz 6286243
Merge pull request #1782 from equalizedigital/steve/pro-1039-update-t…
SteveJonesDev d0b7001
Merge remote-tracking branch 'origin/feature/naked-link-rule' into de…
pattonwebz e8f9d0d
Replace 'Ingore' with 'Dismiss' in LinkTextIsUrlRule strings
pattonwebz ed3e855
Fix: correct 'contentinfo' landmark label from 'Content Info' to 'Con…
pattonwebz fd95d0a
Update pot file with latest translations
pattonwebz 9962a9d
PRO-1041: Default Block Editor Metabox setting to checked for new ins…
SteveJonesDev 3e019c4
Tests: add test verifying reactivation preserves existing metabox pre…
pattonwebz dbcbd61
Merge branch 'release/1.44.0' into steve/pro-1041-default-block-edito…
SteveJonesDev 1dd5138
Merge pull request #1784 from equalizedigital/steve/pro-1041-default-…
SteveJonesDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,201 @@ | ||
| name: Accessibility Report | ||
| description: Let us know if you encounter an accessibility issue so we can fix it. | ||
| title: "[Accessibility]: " | ||
| labels: | ||
| - a11y | ||
| - needs-triage | ||
| assignees: | ||
| - amberhinds | ||
|
|
||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Please use this template when creating an accessibility issue. | ||
|
|
||
| - Please use the latest version of Accessibility Checker. | ||
| - Search for existing issues before creating a new one. | ||
|
|
||
| - type: checkboxes | ||
| id: prerequisites | ||
| attributes: | ||
| label: Before submitting | ||
| options: | ||
| - label: I've read and understood the [contribution guidelines](https://github.com/equalizedigital/accessibility-checker/blob/develop/.github/CONTRIBUTING.md). | ||
| required: true | ||
| - label: I've searched for [related issues](https://github.com/equalizedigital/accessibility-checker/issues) and confirmed this is not a duplicate. | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: impacted-element | ||
| attributes: | ||
| label: Impacted element or component | ||
| description: What part of the plugin or interface is affected? | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: description | ||
| attributes: | ||
| label: Description of the issue | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: screenshots | ||
| attributes: | ||
| label: Screenshot(s) or video | ||
| description: Attach screenshots or paste links to videos demonstrating the issue. | ||
|
|
||
| - type: textarea | ||
| id: recommended-fix | ||
| attributes: | ||
| label: Recommended fix or expected behavior | ||
|
|
||
| - type: dropdown | ||
| id: severity | ||
| attributes: | ||
| label: Is this a critical blocker? | ||
| options: | ||
| - Yes - there is no workaround for this issue. | ||
| - No - this is an accessibility problem, but it is minor or not a blocker. | ||
| - Unsure | ||
|
|
||
| - type: dropdown | ||
| id: wcag-sc | ||
| attributes: | ||
| label: Related WCAG Success Criterion | ||
| description: Select the WCAG Success Criterion that is most closely related to this issue. | ||
| options: | ||
| - Not sure | ||
| - 1.1.1 Non-text Content | ||
| - 1.2.1 Audio-only and Video-only (Prerecorded) | ||
| - 1.2.2 Captions (Prerecorded) | ||
| - 1.2.3 Audio Description or Media Alternative (Prerecorded) | ||
| - 1.2.4 Captions (Live) | ||
| - 1.2.5 Audio Description (Prerecorded) | ||
| - 1.3.1 Info and Relationships | ||
| - 1.3.2 Meaningful Sequence | ||
| - 1.3.3 Sensory Characteristics | ||
| - 1.3.4 Orientation | ||
| - 1.3.5 Identify Input Purpose | ||
| - 1.4.1 Use of Color | ||
| - 1.4.2 Audio Control | ||
| - 1.4.3 Contrast (Minimum) | ||
| - 1.4.4 Resize Text | ||
| - 1.4.5 Images of Text | ||
| - 1.4.10 Reflow | ||
| - 1.4.11 Non-text Contrast | ||
| - 1.4.12 Text Spacing | ||
| - 1.4.13 Content on Hover or Focus | ||
| - 2.1.1 Keyboard | ||
| - 2.1.2 No Keyboard Trap | ||
| - 2.1.4 Character Key Shortcuts | ||
| - 2.2.1 Timing Adjustable | ||
| - 2.2.2 Pause, Stop, Hide | ||
| - 2.3.1 Three Flashes or Below Threshold | ||
| - 2.4.1 Bypass Blocks | ||
| - 2.4.2 Page Titled | ||
| - 2.4.3 Focus Order | ||
| - 2.4.4 Link Purpose (In Context) | ||
| - 2.4.5 Multiple Ways | ||
| - 2.4.6 Headings and Labels | ||
| - 2.4.7 Focus Visible | ||
| - 2.4.11 Focus Not Obscured (Minimum) | ||
| - 2.5.1 Pointer Gestures | ||
| - 2.5.2 Pointer Cancellation | ||
| - 2.5.3 Label in Name | ||
| - 2.5.4 Motion Actuation | ||
| - 2.5.7 Dragging Movements | ||
| - 2.5.8 Target Size (Minimum) | ||
| - 3.1.1 Language of Page | ||
| - 3.2.1 On Focus | ||
| - 3.2.2 On Input | ||
| - 3.2.3 Consistent Navigation | ||
| - 3.2.4 Consistent Identification | ||
| - 3.2.6 Consistent Help | ||
| - 3.3.1 Error Identification | ||
| - 3.3.2 Labels or Instructions | ||
| - 3.3.3 Error Suggestion | ||
| - 3.3.4 Error Prevention (Legal, Financial, Data) | ||
| - 3.3.7 Redundant Entry | ||
| - 3.3.8 Accessible Authentication (Minimum) | ||
| - 4.1.1 Parsing | ||
| - 4.1.2 Name, Role, Value | ||
| - 4.1.3 Status Messages | ||
|
|
||
| - type: textarea | ||
| id: reproduction | ||
| attributes: | ||
| label: How can we reproduce this behavior? | ||
| placeholder: | | ||
| 1. Go to... | ||
| 2. Click... | ||
| 3. Observe... | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: input | ||
| id: wordpress-version | ||
| attributes: | ||
| label: WordPress version | ||
| placeholder: e.g. 7.0 | ||
|
|
||
| - type: input | ||
| id: accessibility-checker-version | ||
| attributes: | ||
| label: Accessibility Checker version | ||
| placeholder: e.g. 1.43.0 | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: input | ||
| id: active-theme | ||
| attributes: | ||
| label: Active theme | ||
| placeholder: e.g. Twenty Twenty-Six | ||
|
|
||
| - type: checkboxes | ||
| id: screen-reader | ||
| attributes: | ||
| label: Which screen reader are you using? (if applicable) | ||
| options: | ||
| - label: NVDA | ||
| - label: VoiceOver | ||
| - label: JAWS | ||
| - label: Other | ||
|
|
||
| - type: input | ||
| id: other-screen-reader | ||
| attributes: | ||
| label: Other screen reader | ||
| placeholder: Specify if you selected Other | ||
|
|
||
| - type: checkboxes | ||
| id: browser | ||
| attributes: | ||
| label: Which browser is affected? | ||
| options: | ||
| - label: Internet Explorer | ||
| - label: Edge | ||
| - label: Chrome | ||
| - label: Firefox | ||
| - label: Safari | ||
| - label: Brave | ||
|
|
||
| - type: checkboxes | ||
| id: editor | ||
| attributes: | ||
| label: Which editor is affected? (if relevant) | ||
| options: | ||
| - label: Classic Editor | ||
| - label: Gutenberg | ||
| - label: Classic Editor Plugin | ||
| - label: Page Builder | ||
|
|
||
| - type: input | ||
| id: page-builder | ||
| attributes: | ||
| label: Page Builder name | ||
| placeholder: Elementor, Beaver Builder, Divi, etc. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.