Skip to content

Set “Confirmed accessible” as first/default dismiss reason - #1793

Merged
SteveJonesDev merged 3 commits into
developfrom
copilot/change-order-dismiss-reasons
Jun 26, 2026
Merged

Set “Confirmed accessible” as first/default dismiss reason#1793
SteveJonesDev merged 3 commits into
developfrom
copilot/change-order-dismiss-reasons

Conversation

Copilot AI commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

The dismiss workflow defaulted to False positive because reason ordering drove default selection in multiple UIs. This updates the canonical reason order so Confirmed accessible is first and therefore selected by default when no prior reason exists.

  • Canonical reason ordering (PHP source of truth)

    • Reordered IgnoreUI::get_reasons() so accessible is first.
    • Retains existing reason keys and translatable strings; only ordering/default behavior changes.
  • Issue Modal default alignment (React)

    • Updated DismissPanel initial fallback from false_positive to accessible so modal behavior matches canonical ordering.
  • Jest fixtures + behavior coverage

    • Updated shared dismiss reason fixtures to reflect new label/description text and ordering.
    • Added assertion that new dismissals submit accessible as the default reason.
    • Updated helper tests to verify first option ordering and current accessible copy.
// admin/class-ignore-ui.php
return [
	'accessible' => [
		'label'       => __( 'Confirmed accessible', 'accessibility-checker' ),
		'description' => __( 'Reviewed and verified to meet accessibility requirements.', 'accessibility-checker' ),
	],
	'false_positive' => [ /* ... */ ],
	'remediated' => [ /* ... */ ],
];

Copilot AI and others added 2 commits June 23, 2026 21:44
Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>
Copilot AI changed the title [WIP] Change the order of the dismiss reasons to make accessible reason default Set “Confirmed accessible” as first/default dismiss reason Jun 23, 2026
Copilot AI requested a review from pattonwebz June 23, 2026 21:50
@github-actions

Copy link
Copy Markdown
Contributor

✅ Accessibility Checker build (primary only)

@pattonwebz
pattonwebz marked this pull request as ready for review June 23, 2026 22:01
@SteveJonesDev
SteveJonesDev merged commit 0b730a4 into develop Jun 26, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants