Skip to content

PTC accessibility-checker (1985): Automatic Translations June 26, 2026 21:58:35270426 #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SteveJonesDev wants to merge 33 commits into
base: develop
Choose a base branch
from
Open

PTC accessibility-checker (1985): Automatic Translations June 26, 2026 21:58:35270426 #1796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
6177ddb
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
a9bf67c
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
033a6c2
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
5b4ff82
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
2cc25dc
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
fc9dc8a
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
ea2b5f4
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
baf5cfd
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
45b3489
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
d19a3da
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
8d1be0e
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
37c4c5a
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
c919d04
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
27d6e74
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
fc02234
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
8f705af
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
279930f
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
13c1a13
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
822276f
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
65b488a
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
1eafdfc
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
694529d
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
7cf4f37
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
896ccdb
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
1c8d657
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
71ec804
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
599c2ab
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
6c47852
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
3e6e4db
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
be0e9e6
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
fe47254
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
b017420
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
1d6d18c
PTC accessibility-checker (1985): Automatic Translations June 26, 202…
Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified languages/accessibility-checker-ko_KR.mo
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion languages/accessibility-checker-ko_KR.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ msgstr "우리 웹사이트에 대한 의견, 질문, 피드백을 환영합니
#: admin/class-admin-footer-text.php:46
#, php-format
msgid "Enjoying Accessibility Checker? %1$sPlease leave us a ★★★★★ rating.%2$s We really appreciate your support!"
msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%p#07527667] 여러분의 지원에 정말 감사드립니다!"
msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%%p#07527667] 여러분의 지원에 정말 감사드립니다!"

@gemini-code-assist gemini-code-assist Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The translation is missing the %2$s placeholder, which is required to output the closing tag. Instead, it contains a corrupted placeholder [/%%p#07527667]. This will cause the tag to remain unclosed in the admin footer, breaking the HTML structure and accessibility of the page. Replacing [/%%p#07527667] with %2$s resolves this issue.

msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.%2$s 여러분의 지원에 정말 감사드립니다!"

@coderabbitai coderabbitai Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Restore the %2$s closing placeholder here.

This translation drops the required %2$s placeholder and replaces it with a literal token, so the footer link from admin/class-admin-footer-text.php:38-50 never gets its closing </a>. That will leak garbage text into the UI and can leave the rest of the footer inside the anchor.

🛠️ Proposed fix 
-msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%%p#07527667] 여러분의 지원에 정말 감사드립니다!"
+msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.%2$s 여러분의 지원에 정말 감사드립니다!"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%%p#07527667] 여러분의 지원에 정말 감사드립니다!"
msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.%2$s 여러분의 지원에 정말 감사드립니다!"
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@languages/accessibility-checker-ko_KR.po` at line 484, The Korean translation
for the admin footer text is missing the required closing %2$s placeholder and
currently uses a literal token instead, so update this msgstr to preserve both
placeholders used by Admin_Footer_Text in class-admin-footer-text.php and
restore the closing placeholder exactly where the link should end. Keep the
translated wording, but ensure the placeholder sequence matches the source
string so the footer anchor is closed correctly and no stray text leaks into the
UI.

Source: Learnings

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the closing link placeholder

In the Korean locale, this php-format translation is passed to sprintf() in Admin_Footer_Text::filter_footer_text() with both the opening and closing anchor; %% renders as a literal percent, so %2$s is never consumed. On Pro-active settings pages the footer output leaves the rating link unclosed and displays the [/%p#07527667] artifact instead of inserting </a>, so the closing placeholder should be restored to %2$s.

Useful? React with 👍 / 👎.


#: admin/class-admin-footer-text.php:47
msgid "Please leave us a five star rating (opens in new window)"
Expand Down
Loading