PTC accessibility-checker (1985): Automatic Translations June 30, 2026 21:25:33332358 - #1812
Conversation
📝 WalkthroughWalkthroughThis PR updates 30 language ChangesTranslation Catalog Updates
Sequence Diagram(s)Not applicable — this PR consists solely of translation catalog (.po) metadata and string updates with no functional control flow changes. Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates multiple localization files (.po) to version 1.44.1, adding and adjusting translations across various languages. A critical issue was found in the Korean translation file where a corrupted placeholder was used instead of the required '%2$s' format specifier, which could cause unclosed HTML tags and display raw translation tool markup to users.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| #, php-format | ||
| msgid "Enjoying Accessibility Checker? %1$sPlease leave us a ★★★★★ rating.%2$s We really appreciate your support!" | ||
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%p#07527667] 여러분의 지원에 정말 감사드립니다!" | ||
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%%p#07527667] 여러분의 지원에 정말 감사드립니다!" |
There was a problem hiding this comment.
The translation contains a corrupted placeholder [/%%p#07527667] instead of the required %2$s format specifier. This will result in unclosed HTML tags (as %1$s likely opens a link or formatting that %2$s is supposed to close) and displays raw translation tool markup to the end-user. Please restore the %2$s placeholder.
msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.%2$s 여러분의 지원에 정말 감사드립니다!"
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e1c5f229e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #, php-format | ||
| msgid "Enjoying Accessibility Checker? %1$sPlease leave us a ★★★★★ rating.%2$s We really appreciate your support!" | ||
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%p#07527667] 여러분의 지원에 정말 감사드립니다!" | ||
| msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%%p#07527667] 여러분의 지원에 정말 감사드립니다!" |
There was a problem hiding this comment.
For Korean sites where Pro is active, filter_footer_text() passes both an opening and closing link into sprintf, but this updated translation escapes the stray marker as %%p and still omits %2$s. That means the closing </a> is never inserted and the footer renders the literal [/%%p#07527667] with an unterminated review link instead of closing after the stars; this should use the %2$s placeholder for the closing tag.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
languages/accessibility-checker-ko_KR.po (1)
480-484: 🗄️ Data Integrity & Integration | 🔴 Critical | ⚡ Quick winCorrupted placeholder breaks the footer rating link.
The
msgstrreplaces the%2$sclosing-tag placeholder with garbage text[/%%p#07527667]instead of keeping%2$s. The PHP source (admin/class-admin-footer-text.php) callssprintf()with%1$sas the opening<a>tag and%2$sas the closing</a>tag. Since the translated string no longer contains%2$s, the closing anchor tag will never be substituted in, producing malformed/unclosed HTML in the admin footer.🐛 Proposed fix
-msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.[/%%p#07527667] 여러분의 지원에 정말 감사드립니다!" +msgstr "Accessibility Checker를 즐겁게 사용하고 계신가요? %1$s★★★★★ 평가를 남겨주세요.%2$s 여러분의 지원에 정말 감사드립니다!"Based on learnings, this falls under the explicit exception for PO translation reviews ("placeholder mismatches" should be flagged even when other copy/POT changes are deprioritized).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@languages/accessibility-checker-ko_KR.po` around lines 480 - 484, The Korean translation for the admin footer rating prompt has a corrupted placeholder in the msgstr, where the `%2$s` closing-link token was replaced with garbage text. Restore the exact `%1$s` and `%2$s` placeholders in the translation for `admin/class-admin-footer-text.php` so `sprintf()` can insert both the opening and closing anchor tags correctly and the footer HTML remains well-formed.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@languages/accessibility-checker-ko_KR.po`:
- Around line 480-484: The Korean translation for the admin footer rating prompt
has a corrupted placeholder in the msgstr, where the `%2$s` closing-link token
was replaced with garbage text. Restore the exact `%1$s` and `%2$s` placeholders
in the translation for `admin/class-admin-footer-text.php` so `sprintf()` can
insert both the opening and closing anchor tags correctly and the footer HTML
remains well-formed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cf562e12-5338-412f-9249-fed524c9e145
📒 Files selected for processing (66)
languages/accessibility-checker-ar.molanguages/accessibility-checker-ar.polanguages/accessibility-checker-bg_BG.molanguages/accessibility-checker-bg_BG.polanguages/accessibility-checker-cs_CZ.molanguages/accessibility-checker-cs_CZ.polanguages/accessibility-checker-da_DK.molanguages/accessibility-checker-da_DK.polanguages/accessibility-checker-de_DE.molanguages/accessibility-checker-de_DE.polanguages/accessibility-checker-el.molanguages/accessibility-checker-el.polanguages/accessibility-checker-es_ES.molanguages/accessibility-checker-es_ES.polanguages/accessibility-checker-et.molanguages/accessibility-checker-et.polanguages/accessibility-checker-fi.molanguages/accessibility-checker-fi.polanguages/accessibility-checker-fr_FR.molanguages/accessibility-checker-fr_FR.polanguages/accessibility-checker-he_IL.molanguages/accessibility-checker-he_IL.polanguages/accessibility-checker-hu_HU.molanguages/accessibility-checker-hu_HU.polanguages/accessibility-checker-id_ID.molanguages/accessibility-checker-id_ID.polanguages/accessibility-checker-it_IT.molanguages/accessibility-checker-it_IT.polanguages/accessibility-checker-ja.molanguages/accessibility-checker-ja.polanguages/accessibility-checker-ko_KR.molanguages/accessibility-checker-ko_KR.polanguages/accessibility-checker-lt_LT.molanguages/accessibility-checker-lt_LT.polanguages/accessibility-checker-lv.molanguages/accessibility-checker-lv.polanguages/accessibility-checker-nb_NO.molanguages/accessibility-checker-nb_NO.polanguages/accessibility-checker-nl_NL.molanguages/accessibility-checker-nl_NL.polanguages/accessibility-checker-pl_PL.molanguages/accessibility-checker-pl_PL.polanguages/accessibility-checker-pt_BR.molanguages/accessibility-checker-pt_BR.polanguages/accessibility-checker-pt_PT.molanguages/accessibility-checker-pt_PT.polanguages/accessibility-checker-ro_RO.molanguages/accessibility-checker-ro_RO.polanguages/accessibility-checker-ru_RU.molanguages/accessibility-checker-ru_RU.polanguages/accessibility-checker-sk_SK.molanguages/accessibility-checker-sk_SK.polanguages/accessibility-checker-sl_SI.molanguages/accessibility-checker-sl_SI.polanguages/accessibility-checker-sv_SE.molanguages/accessibility-checker-sv_SE.polanguages/accessibility-checker-th.molanguages/accessibility-checker-th.polanguages/accessibility-checker-tr_TR.molanguages/accessibility-checker-tr_TR.polanguages/accessibility-checker-uk.molanguages/accessibility-checker-uk.polanguages/accessibility-checker-vi.molanguages/accessibility-checker-vi.polanguages/accessibility-checker-zh_CN.molanguages/accessibility-checker-zh_CN.po
2 participants
For the complete list of PTC PRs see the Pull Request History tab.
Summary by CodeRabbit