[Backport] Release v1.45.0 - #1813
Merged
Merged
Conversation
The DismissPanel and IssueDetailsModal were reading pro status only from window.edac_editor_app, which is only localized on post edit screens. When the issue modal is opened from the Issues Explorer (an admin page), that global is undefined and isPro evaluates to false — hiding the global dismiss dropdown and silently breaking GlobalDismissModal's forceGlobal behaviour. Add a `pro` key to edac_script_vars (available on all admin pages) and update the two isPro checks to fall back to window.edac_script_vars?.pro so pro detection works regardless of which admin context opens the modal. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
issue?.ignre_global is 0 (a number) when not globally dismissed. When user/date/name are also empty strings, the || chain resolves to 0 and React renders it as text. Replace with isGloballyDismissed which is already computed as a boolean from the same field. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add a unit test verifying the pro flag in edac_script_vars - Wrap DismissPanel's destructured params across multiple lines (line was 200+ chars) - Guard the window reference in IssueDetailsModal's pro check with typeof window !== 'undefined' - Drop the isPro prop passed to DismissPanel since it duplicated the component's own default Co-Authored-By: Claude <noreply@anthropic.com>
…o-detection-in-dismiss-panel-outside-post-editor fix: expose pro status in edac_script_vars and widen isPro checks in DismissPanel
…lity-checker into release/1.45.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Backport
This is an automatic backport of PR #1811 by @pattonwebz to the
developbranch.Original PR Details:
Steve Jones (2):
William Patton (4):
This PR was created automatically when #1811 was merged into
main.