Skip to content

Fix inaccurate accessible name on settings navigation landmark #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveJonesDev merged 3 commits into from
Jul 5, 2026
Merged

Fix inaccurate accessible name on settings navigation landmark #1822

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ce633e
fix: use accurate accessible name for settings navigation landmark
SteveJonesDev Jul 5, 2026
36f7c0d
fix: use "Accessibility Checker Settings" per maintainer feedback
SteveJonesDev Jul 5, 2026
7e09d1f
fix: make settings nav landmark aria-label translatable
SteveJonesDev Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion partials/settings-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function ( $a, $b ) {

<?php
if ( $edac_settings_tab_items ) {
echo '<nav class="nav-tab-wrapper" aria-label="Settings Tabs">';
echo '<nav class="nav-tab-wrapper" aria-label="Settings">';

@gemini-code-assist gemini-code-assist Bot Jul 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The aria-label value "Settings" is a user-facing string (read by screen readers) but is currently hardcoded in English. To support internationalization (i18n), it should be translatable using WordPress translation functions like esc_attr__().

        echo '<nav class="nav-tab-wrapper" aria-label="' . esc_attr__( 'Settings', 'accessibility-checker' ) . '">';

Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
foreach ( $edac_settings_tab_items as $edac_settings_tab_item ) {
$edac_slug = $edac_settings_tab_item['slug'] ? $edac_settings_tab_item['slug'] : null;
$edac_query_var = $edac_slug ? '&tab=' . $edac_slug : '';
Expand Down
Loading