Announce accessibility analysis refresh completion - #1838
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
📝 WalkthroughWalkthroughThe sidebar refresh action now returns a success status, announces successful or failed refreshes through ChangesRefresh accessibility status
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Hey @benitoalba this looks good to me on a quick scan. I see you just swapped it out of draft state as well, do you think this is good to test? |
|
Yes, it’s ready to test from my side. All the local automated and manual checks listed in the PR description are passing, including the NVDA verification. Please let me know if you’d like me to test any additional scenarios. |
|
@benitoalba this looks good to me. I just tested it and it all appears to work fine. I did run into an edge case when testing caused by a denounce timer that would incorrectly cancel the wrong promise meaning a small chance of the wrong announcement being fired. It is a pre-existing issue though so no need to fix it in this PR - I made a followup issue that I will tackle before we do the next release. I think this will be good to merge in after I test it a little more and will probably go out in the next release. Thanks for the contribution, also nice addition of the tests! 😄 |
Fixes #1761
Summary
wp.a11y.speak.wp-a11ywith the sidebar bundle and add JavaScript and PHP regression coverage.Why
The Refresh action updated the sidebar asynchronously but did not expose a completion status to assistive technologies. Screen reader users therefore had no confirmation that refreshed results were available.
Testing
npm run test:jest -- --runInBand— 956 tests passed.docker compose exec -T phpunit vendor/bin/phpunit— 874 tests, 1,867 assertions, 15 skipped.npm run lint:js -- src/sidebar/components/SidebarTitleMenu.js src/sidebar/store/accessibility-checker-store.js tests/jest/sidebar/SidebarTitleMenu.test.js tests/jest/sidebar/accessibility-checker-store.test.js— passed.docker compose exec -T phpunit vendor/bin/phpcs admin/class-enqueue-admin.php tests/phpunit/Admin/EnqueueAdminTest.php— passed.npm run build— passed.git diff --check— passed.Checklist
Summary by CodeRabbit
Accessibility
Bug Fixes
Tests