Skip to content

chore: update WPCS to patch CVE-2026-45293 - #1854

Merged
pattonwebz merged 2 commits into
developfrom
william/pro-1246-update-phpcswpcs-accessibility-checker
Jul 28, 2026
Merged

chore: update WPCS to patch CVE-2026-45293#1854
pattonwebz merged 2 commits into
developfrom
william/pro-1246-update-phpcswpcs-accessibility-checker

Conversation

@pattonwebz

Copy link
Copy Markdown
Member

Summary

  • WPCS (wp-coding-standards/wpcs) versions >= 0.14.1, < 3.4.1 have an eval() arbitrary code execution vulnerability in the WordPress.WP.EnqueuedResourceParameters sniff (CVE-2026-45293). This repo was locked to 3.3.0, which is vulnerable.
  • Ran composer update wp-coding-standards/wpcs automattic/vipwpcs --with-all-dependencies to bring in the patched 3.4.1 (and vipwpcs 3.1.0, which bumped its own wpcs requirement). composer.json constraints already allowed these versions, so only composer.lock changed.
  • Re-ran phpcs; no new violations from the updated ruleset (one pre-existing, unrelated warning in a test file).

Linear: PRO-1246 (subtask of PRO-1245)

Test plan

  • composer update wp-coding-standards/wpcs automattic/vipwpcs --with-all-dependencies
  • composer check-cs — no new violations

🤖 Generated with Claude Code

Bumps wp-coding-standards/wpcs to 3.4.1 and automattic/vipwpcs to
3.1.0 (composer.lock only; composer.json constraints already allowed
these versions). WPCS < 3.4.1 has an eval() arbitrary code execution
vulnerability in the WordPress.WP.EnqueuedResourceParameters sniff
(CVE-2026-45293 / GHSA-3pwp-g2mj-5p3v).

Ran phpcs against the updated ruleset; no new violations, only a
pre-existing unrelated warning in a test file.

Refs PRO-1246

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 07769040-74e9-48f8-bdeb-54f0df250530

📥 Commits

Reviewing files that changed from the base of the PR and between ae5de11 and 4ee8398.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • tests/phpunit/includes/OptionsPageSourceTest.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch william/pro-1246-update-phpcswpcs-accessibility-checker

Comment @coderabbitai help to get the list of available commands.

WordPressVIPMinimum.Performance.FetchingRemoteData.FileGetContentsUnknown
flagged the file_get_contents() call in OptionsPageSourceTest because
it can't statically verify the path isn't a URL. The argument is
EDAC_PLUGIN_DIR . 'includes/options-page.php' — always a local path,
never remote — so this is a false positive. Suppressed with
phpcs:ignore and a justification comment.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@pattonwebz

Copy link
Copy Markdown
Member Author

Pushed a follow-up commit: the one pre-existing warning noted in the PR description (WordPressVIPMinimum.Performance.FetchingRemoteData.FileGetContentsUnknown in OptionsPageSourceTest.php) was causing a CI failure. Confirmed it's a false positive — file_get_contents( EDAC_PLUGIN_DIR . 'includes/options-page.php' ) reads a local plugin file, not a remote URL; the sniff just can't tell that statically from the constant-concatenated path. Suppressed with phpcs:ignore + justification. composer check-cs is now fully clean (0 errors, 0 warnings).

@pattonwebz
pattonwebz merged commit b2fcc98 into develop Jul 28, 2026
13 checks passed
@pattonwebz
pattonwebz deleted the william/pro-1246-update-phpcswpcs-accessibility-checker branch July 28, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant