StyleLint: resolve remaining manual-fix findings - #1860
Merged
pattonwebz merged 11 commits intoJul 31, 2026
Merged
Conversation
…ore some no-decending-specificallity
Selectors here are ordered for readability/grouping rather than cascade order, and reordering them to satisfy the linter would risk changing which rules win. Disable file-wide in files with many instances (accessibility-checker-admin.scss, app.scss, issue-modal.scss) and per-declaration in files with only one or two (_fix-settings.scss, _dismiss-panel.scss). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
IDs like #TB_ajaxContent and #edac_welcome_page_summary come from WordPress/third-party markup we don't control and don't follow the lowercase-hyphenated pattern. Rather than sprinkling stylelint-disable-next-line comments at every use, disable the rule in .stylelintrc.json. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Keep the legacy single-colon :before/:after notation as-is rather than rewriting to ::before/::after, and suppress the rule at each occurrence with stylelint-disable comments. Comma-separated selector lists needed a disable/enable block instead of disable-next-line, since the linter doesn't apply next-line suppression to selectors nested inside a list. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Fix @stylistic/max-line-length findings by wrapping comment text onto multiple lines. No selectors or declarations changed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Config restricts line-height to px, but rem/em here are intentional so spacing scales with the user's font-size preference (accessibility zoom) instead of being locked to a fixed pixel value. Suppress the rule at each occurrence rather than converting units. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
-webkit-min-device-pixel-ratio / min-device-pixel-ratio predate the CSS Media Queries spec and were superseded by min-resolution, but are kept here for older browser support. Suppress the rule rather than switching to min-resolution and dropping that fallback. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…tends .edac-highlight-panel-description--button is used directly in markup (index.js), so it can't be converted to a %placeholder without also duplicating it as a real class. Suppress the rule at each @extend rather than restructuring the shared styles. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…l split The reset block and the real styling block are deliberately separate so the reset runs before fix-settings loads. Suppress the rule at the second block since the comment on the first already explains why. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
william/no-issue/stylelint-fix-indentation, working through everything that couldn't be safely auto-fixed.no-descending-specificity: disabled file-wide where instances were numerous (admin CSS, app.scss, issue-modal.scss), per-declaration where only one or two.selector-id-pattern: disabled the rule entirely in.stylelintrc.json— IDs like#TB_ajaxContentand WP/third-party markup don't follow the lowercase-hyphenated pattern and never will.selector-pseudo-element-colon-notation: kept legacy single-colon:before/:afteras-is, suppressed per occurrence.@stylistic/max-line-length: wrapped over-length comment lines (no code changes).declaration-property-unit-allowed-list: keptrem/emonline-heightintentionally so it scales with user font-size preference (accessibility zoom) instead of locking topx.media-feature-name-no-unknown: kept legacy-webkit-min-device-pixel-ratio/min-device-pixel-ratioretina fallback, notedmin-resolution: 2dppxas the modern equivalent.scss/at-extend-no-missing-placeholder:@extends a real class used directly in markup, not convertible to a%placeholderwithout duplicating it.no-duplicate-selectors: intentional split.edac-fixes-modalblock (reset beforefix-settingsloads, then real styling after) — noted why it's safe.npm run lint:cssis fully clean (0 problems) on this branch.Test plan
npm run lint:csspasses with 0 errors🤖 Generated with Claude Code