Remove orphaned edac_insert_ignore_data AJAX handler (PRO-963) - #1862
Merged
pattonwebz merged 1 commit intoAug 4, 2026
Conversation
add_ignore() and its wp_ajax_edac_insert_ignore_data registration were the ignore/dismiss mechanism before the REST dismiss-issue endpoint replaced it. The last caller was the Pro plugin's legacy Open/Dismissed Issues pages, removed in PRO-961. Verified dead before removing: no references in the free plugin's current src/admin/index.js, no callers anywhere in accessibility-checker-pro or the multisite/audit-history/cli/export/seed-issues sibling add-ons (only old dist/ build archives from past releases still mention it), and no test coverage exercised it. It also carried the same object-only batch-scoping leak as PRO-1264 (no rule filter on its largeBatch UPDATE), which is now moot since the handler is gone rather than patched. Full PHPUnit suite (874 tests) and phpcs pass.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe legacy AJAX hook and Changes
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ajax::add_ignore()and itswp_ajax_edac_insert_ignore_dataregistration inadmin/class-ajax.php. This admin-ajax action was the ignore/dismiss mechanism before the RESTdismiss-issueendpoint (includes/classes/class-rest-api.php) replaced it.edacpInsertIgnoreData), removed in PRO-961.rulefilter on itslargeBatchUPDATE at the old line 895) — rather than patch a dead handler, this removes it per the ticket's own recommendation.Verification before removing (per the ticket's caveat about a public wp_ajax_ action)
src/,admin/,includes/(only olddist/*/release archives from years-old versions still mention it — irrelevant build artifacts, not live code).accessibility-checker-pro,accessibility-checker-multisite,accessibility-checker-audit-history,accessibility-checker-cli,accessibility-checker-export, oraccessibility-checker-seed-issues.ajax-nonceused by this handler is also used by the other still-active AJAX handlers in the same class, so nothing else needed cleanup.Test plan
php -lcleanLinear: PRO-963
🤖 Generated with Claude Code
Summary by CodeRabbit