Skip to content

Remove orphaned edac_insert_ignore_data AJAX handler (PRO-963) - #1862

Merged
pattonwebz merged 1 commit into
developfrom
william/pro-963-free-remove-orphaned-edac_insert_ignore_data-ajax-handler
Aug 4, 2026
Merged

Remove orphaned edac_insert_ignore_data AJAX handler (PRO-963)#1862
pattonwebz merged 1 commit into
developfrom
william/pro-963-free-remove-orphaned-edac_insert_ignore_data-ajax-handler

Conversation

@pattonwebz

@pattonwebz pattonwebz commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Removes Ajax::add_ignore() and its wp_ajax_edac_insert_ignore_data registration in admin/class-ajax.php. This admin-ajax action was the ignore/dismiss mechanism before the REST dismiss-issue endpoint (includes/classes/class-rest-api.php) replaced it.
  • The last known caller was the Pro plugin's legacy Open/Dismissed Issues pages JS (edacpInsertIgnoreData), removed in PRO-961.
  • Surfaced during the PRO-1264 code review: this handler carried the identical object-only batch-scoping leak just fixed on the REST path (no rule filter on its largeBatch UPDATE at the old line 895) — rather than patch a dead handler, this removes it per the ticket's own recommendation.

Verification before removing (per the ticket's caveat about a public wp_ajax_ action)

  • No references anywhere in the free plugin's current src/, admin/, includes/ (only old dist/*/ release archives from years-old versions still mention it — irrelevant build artifacts, not live code).
  • No references in accessibility-checker-pro, accessibility-checker-multisite, accessibility-checker-audit-history, accessibility-checker-cli, accessibility-checker-export, or accessibility-checker-seed-issues.
  • No test coverage exercised this handler (nothing broke by removing it).
  • The shared ajax-nonce used by this handler is also used by the other still-active AJAX handlers in the same class, so nothing else needed cleanup.

Test plan

  • php -l clean
  • Full PHPUnit suite passes (874 tests, down from 875 on develop — no test targeted the removed handler)
  • phpcs clean on the changed file
  • Dismiss/undismiss via the REST endpoint is unaffected (separate code path, untouched)

Linear: PRO-963

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor
    • Removed ignore/dismissal functionality that was previously handled through an AJAX endpoint.

add_ignore() and its wp_ajax_edac_insert_ignore_data registration were
the ignore/dismiss mechanism before the REST dismiss-issue endpoint
replaced it. The last caller was the Pro plugin's legacy Open/Dismissed
Issues pages, removed in PRO-961.

Verified dead before removing: no references in the free plugin's
current src/admin/index.js, no callers anywhere in accessibility-checker-pro
or the multisite/audit-history/cli/export/seed-issues sibling add-ons
(only old dist/ build archives from past releases still mention it),
and no test coverage exercised it. It also carried the same object-only
batch-scoping leak as PRO-1264 (no rule filter on its largeBatch UPDATE),
which is now moot since the handler is gone rather than patched.

Full PHPUnit suite (874 tests) and phpcs pass.
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f76c4918-4e47-47ff-bf01-a59d75ca33cd

📥 Commits

Reviewing files that changed from the base of the PR and between 0990d34 and 8adf14c.

📒 Files selected for processing (1)
  • admin/class-ajax.php
💤 Files with no reviewable changes (1)
  • admin/class-ajax.php

📝 Walkthrough

Walkthrough

The legacy AJAX hook and EDAC\Admin\Ajax::add_ignore() method were removed from admin/class-ajax.php. Ignore updates no longer use this AJAX endpoint.

Changes

Cohort / File(s) Summary
Ignore handler removal
admin/class-ajax.php
Removes the edac_insert_ignore_data AJAX registration and the public add_ignore() handler.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the obsolete AJAX handler.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch william/pro-963-free-remove-orphaned-edac_insert_ignore_data-ajax-handler

Comment @coderabbitai help to get the list of available commands.

@pattonwebz
pattonwebz merged commit 3c7163d into develop Aug 4, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant