Staging

AGENTS.md

@@ -5,6 +5,8 @@
 
 # Checks
 - After changing `root` or `functions/`, run: `npm run typecheck && npm run lint && npm run test`
+- After changing `cloud-agent/`, run: `cd cloud-agent && npm run typecheck && npm test`
+- After changing `extension/`, run: `cd extension && npm run typecheck && npm test`
 
 # Git & Commits
 - **Flow**: feature → `staging` → `main` (via PRs only).

CONTRIBUTING.md

@@ -322,10 +322,30 @@ Fixes #456
 ### Running Tests
 
 ```bash
-npm test                # Run all tests
+npm test                # Run all tests (Expo app)
 npm run test:watch      # Run tests in watch mode
 ```
 
+### Cloud Agent Tests
+
+```bash
+cd cloud-agent
+npm run typecheck
+npm test
+```
+
+### Desktop Bridge Extension Tests
+
+```bash
+cd extension
+npm install             # first time only
+npm run typecheck
+npm test
+npm run build           # esbuild → dist/ for unpacked Chrome load
+```
+
+The root `npm run typecheck` excludes `extension/` and `cloud-agent/` — run each package's typecheck separately. Root `tsconfig.json` excludes those directories; they have their own `tsconfig.json` files.
+
 ### Writing Tests
 
 - Add tests for new features in `__tests__` directory

README.md

@@ -9,6 +9,7 @@
 
 ### AI & Chat
 - **[AI & Chat](docs/ai-and-chat.md)** — Chat response pipeline (`generateReply`), chat memory summarization, LLM Wiki Memory (structured facts/tasks/events), wiki state machine architecture, image generation (`generateImage`), and local `cloud-agent` dev (local Postgres + Vertex via ADC; see `docker-compose.local.yml` and `./scripts/migrate-dev.sh`).
+- **[Browser Bridge](docs/browser-bridge.md)** — Clanker Desktop Bridge MV3 extension: cross-device web tasks via `browser_action`, Wake-and-Connect lifecycle, Firestore coordination, approval flow, pairing, and billing.
 - **[Real-Time Voice Chat](docs/real-time-voice-chat.md)** — Talk tab live voice calls via Gemini Live (`/agent/live` WebSocket), XState session lifecycle, audio I/O, pre-flight checks, and native build requirements.
 - **[Edge Agent](docs/edge-agent.md)** — On-device tool orchestration loop (BYOI proxy via `generateReply`), escalation paths, per-round billing, and security policy.
 

app/privacy.tsx

@@ -1,6 +1,7 @@
 import { StyleSheet, ScrollView, View } from 'react-native'
 import { Text, useTheme } from 'react-native-paper'
 import { PRIVACY } from '~/config/privacyConfig'
+import { PolicyMarkdown } from '~/components/PolicyMarkdown'
 
 export default function Privacy() {
   const { colors } = useTheme()
@@ -25,7 +26,7 @@ export default function Privacy() {
 
       <View style={styles.separator} />
       <ScrollView contentContainerStyle={styles.scrollView}>
-        <Text>{PRIVACY.privacy}</Text>
+        <PolicyMarkdown content={PRIVACY.privacy} />
       </ScrollView>
     </View>
   )

cloud-agent/scripts/deploy.sh

@@ -35,8 +35,10 @@ DEPLOY_ARGS=(
   --memory 512Mi
   --timeout 540
   --set-env-vars "GOOGLE_GENAI_USE_VERTEXAI=true,GOOGLE_CLOUD_PROJECT=${PROJECT_ID},GOOGLE_CLOUD_LOCATION=${GEMINI_LOCATION}"
-  # GEMINI_API_KEY secret was deleted (embeddings.ts migrated to Vertex AI ADC);
-  # remove the dangling secret-backed env var carried forward from prior revisions.
+  # Explicitly pin required secrets so every deploy is self-contained.
+  # --update-secrets adds/overwrites only these; other secrets (Cloud SQL x4) are preserved.
+  # GEMINI_API_KEY was deleted from Secret Manager; remove its binding if still present.
+  --update-secrets "SCHEDULER_SECRET=SCHEDULER_SECRET:latest"
   --remove-secrets "GEMINI_API_KEY"
 )
 if [[ "${ALLOW_UNAUTHENTICATED}" == "true" ]]; then

cloud-agent/src/handlers/authApprovalObserver.test.ts

@@ -20,6 +20,7 @@ function baseDeps(over: Record<string, unknown> = {}) {
       wakeExtension: async (...a: unknown[]) => { pushes.push({ type: 'wake', args: a }) },
       sendTaskComplete: async (...a: unknown[]) => { pushes.push({ type: 'complete', args: a }) },
     },
+    verifyToken: async () => ({ uid: 'uid1' }),
     getExpoPushToken: async () => 'ExponentPushToken[x]',
     firebaseUid: 'uid1',
     sessionId: 'sid1',
@@ -53,11 +54,11 @@ test('denied writes aborted + sendTaskComplete and unsubscribes', async () => {
   assert.ok(getUnsubbed())
 })
 
-test('approved sends FCM resume wake without token verification', async () => {
+test('approved verifies token and sends FCM resume wake', async () => {
   const { deps, getWatcher, pushes } = baseDeps()
   startAuthApprovalObserver(deps as never)
 
-  getWatcher()!({ status: 'approved', approvalToken: null, approvedAt: null, expiresAt: 0, actionSummary: '' })
+  getWatcher()!({ status: 'approved', approvalToken: 'valid-token', approvedAt: null, expiresAt: 0, actionSummary: '' })
   await new Promise((r) => setTimeout(r, 10))
 
   assert.equal(pushes.length, 1)
@@ -75,7 +76,7 @@ test('failed FCM wake aborts task instead of resolving', async () => {
   })
   startAuthApprovalObserver(deps as never)
 
-  getWatcher()!({ status: 'approved', approvalToken: null, approvedAt: null, expiresAt: 0, actionSummary: '' })
+  getWatcher()!({ status: 'approved', approvalToken: 'valid-token', approvedAt: null, expiresAt: 0, actionSummary: '' })
   await new Promise((r) => setTimeout(r, 20))
 
   assert.ok(results.length >= 1)
@@ -85,6 +86,23 @@ test('failed FCM wake aborts task instead of resolving', async () => {
   assert.match(result.error.message, /wake/i)
 })
 
+test('invalid approval token aborts task with AUTH_DENIED', async () => {
+  const { deps, getWatcher, results, pushes } = baseDeps({
+    verifyToken: async () => { throw new Error('invalid token') },
+  })
+  startAuthApprovalObserver(deps as never)
+
+  getWatcher()!({ status: 'approved', approvalToken: 'bad-token', approvedAt: null, expiresAt: 0, actionSummary: '' })
+  await new Promise((r) => setTimeout(r, 20))
+
+  assert.equal(results.length, 1)
+  const result = (results[0] as unknown[])[3] as { status: string; error: { code: string; message: string } }
+  assert.equal(result.status, 'aborted')
+  assert.equal(result.error.code, 'AUTH_DENIED')
+  assert.match(result.error.message, /invalid/i)
+  assert.equal(pushes.length, 1)
+})
+
 test('5-minute TTL aborts with AUTH_TIMEOUT and sendTaskComplete', async () => {
   const { deps, results, pushes } = baseDeps({ authApprovalTtlMs: 30 })
   startAuthApprovalObserver(deps as never)

cloud-agent/src/handlers/authApprovalObserver.ts

@@ -7,6 +7,7 @@ export const AUTH_APPROVAL_TTL_MS = 5 * 60 * 1000
 export interface AuthApprovalObserverDeps {
   fs: FirestoreSession
   fcmDispatcher?: FcmDispatcher
+  verifyToken: (token: string) => Promise<{ uid: string }>
   getExpoPushToken?: (uid: string) => Promise<string | null>
   firebaseUid: string
   sessionId: string
@@ -75,6 +76,14 @@ export function startAuthApprovalObserver(deps: AuthApprovalObserverDeps): void
 
     if (auth.status === 'approved') {
       settle(async () => {
+        try {
+          const decoded = await deps.verifyToken(auth.approvalToken ?? '')
+          if (decoded.uid !== deps.firebaseUid) throw new Error('UID mismatch')
+        } catch {
+          await abortTask('AUTH_DENIED', 'Approval token invalid. The action was not completed.')
+          return
+        }
+
         if (deps.fcmDispatcher && deps.deviceFcmToken) {
           try {
             await deps.fcmDispatcher.wakeExtension(deps.deviceFcmToken, deps.sessionId, deps.taskId, true)