Staging#561
Merged
Merged
Conversation
…wiki 4.22.0 The manifest now ships as @equationalapplications/schema-org-llm-wiki (published 4.22.0); this spec becomes Clanker's adoption design instead of an inline manifest definition. Updates: rating→review, attendee, subOrganization, polymorphic edge rows kept (triple-keyed validation in core 4.22.0), deployment path grounded in characterSyncService seeding and existing cloud sync. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
feat: adopt curated Schema.org ontology manifest for warm-agent memory
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adopts the curated Schema.org ontology manifest package for Clanker’s warm-agent memory system by bumping wiki dependencies to 4.22.0, adding the @equationalapplications/schema-org-llm-wiki manifest package, and seeding the manifest during cloud character sync so ontology backfill can run in strict mode.
Changes:
- Bump
@equationalapplications/*-llm-wikideps to^4.22.0and add@equationalapplications/schema-org-llm-wiki@^4.22.0. - Seed
schemaOrgWarmAgentManifest(strict mode) for cloud-linked characters that have no ontology manifest after sync. - Add Jest coverage for seeding behavior + add design spec and implementation plan docs.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/services/characterSyncService.ts | Seeds the curated ontology manifest post-sync (before backfill) for cloud-linked characters with no manifest. |
| tests/characterSyncWiki.test.ts | Adds mocks and tests covering seeding, skip-when-present, failure reporting, and multi-character behavior. |
| package.json | Bumps wiki deps and adds the schema-org manifest package dependency. |
| package-lock.json | Lockfile updates for the bumped/added packages. |
| docs/superpowers/specs/2026-07-14-curated-schema-ontology-design.md | Adds the design spec for the curated Schema.org ontology adoption. |
| docs/superpowers/plans/2026-07-14-schema-org-ontology-adoption.md | Adds an implementation plan documenting the intended rollout and tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Kurt VanDusen <info@equationalapplications.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR adds a curated Schema.org ontology package, seeds missing manifests during cloud character sync, preserves ontology backfill after seed failures, and adds Jest coverage plus design and implementation documentation. ChangesSchema.org ontology adoption
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant SyncAllToCloud
participant Wiki
participant Backfill
participant ErrorReporter
SyncAllToCloud->>Wiki: Read character ontology manifest
SyncAllToCloud->>Wiki: Seed curated manifest in strict mode
SyncAllToCloud->>Backfill: Run ontology backfill
SyncAllToCloud->>ErrorReporter: Report seed failure
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
__tests__/characterSyncWiki.test.ts (1)
555-635: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winTest cloud-restored manifest precedence.
This suite sets
mockSyncAll.mockResolvedValue(undefined), so it never executes therunRemoteSyncpath that restorescloudBundle.ontology. Add a test where sync returns a cloud manifest and verify the later seed check skips overwriting it.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@__tests__/characterSyncWiki.test.ts` around lines 555 - 635, Add a test in the ontology manifest seeding suite that makes mockSyncAll return a cloud bundle containing an ontology manifest, then runs syncAllToCloud and verifies the subsequent seed check does not call mockSetOntologyManifest. Ensure the test covers restoration through the runRemoteSync path and confirms the restored cloud manifest takes precedence over schemaOrgWarmAgentManifest.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/superpowers/plans/2026-07-14-schema-org-ontology-adoption.md`:
- Line 17: Update the task section headings in the plan document from
level-three to level-two headings, including Task 1 through Task 4 and
Self-Review Notes, so they directly follow the document’s level-one title.
- Around line 48-54: Update the “Step 4: Verify nothing broke” section to
replace the separate typecheck and targeted test commands with the required
exact command: npm run typecheck && npm run lint && npm run test. Remove the
outdated expected-output and baseline-test instructions while preserving the
step’s verification purpose.
In `@docs/superpowers/specs/2026-07-14-curated-schema-ontology-design.md`:
- Around line 154-156: Update the “Where the manifest lives at runtime” section
to remove the inaccurate claim that no manifest is seeded and all characters
resolve to mode “off.” Describe the current shipped seed behavior, or qualify
the statement as applying only before ontology adoption, while preserving the
existing sync-path description.
---
Nitpick comments:
In `@__tests__/characterSyncWiki.test.ts`:
- Around line 555-635: Add a test in the ontology manifest seeding suite that
makes mockSyncAll return a cloud bundle containing an ontology manifest, then
runs syncAllToCloud and verifies the subsequent seed check does not call
mockSetOntologyManifest. Ensure the test covers restoration through the
runRemoteSync path and confirms the restored cloud manifest takes precedence
over schemaOrgWarmAgentManifest.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ebe9fc38-5004-4a5d-a157-43893913768f
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
__tests__/characterSyncWiki.test.tsdocs/superpowers/plans/2026-07-14-schema-org-ontology-adoption.mddocs/superpowers/specs/2026-07-14-curated-schema-ontology-design.mdpackage.jsonsrc/services/characterSyncService.ts
- Add seeding test that drives runRemoteSync with a cloud ontology bundle and asserts the seed check defers to the restored manifest - Plan doc: task headings h3 -> h2 (MD001), verification steps use the required `npm run typecheck && npm run lint && npm run test` command - Spec doc: qualify pre-adoption "no manifest seeded" wording now that the seed path has shipped Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
/fix-pr follow-upCommit: Review resolution
Verification
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adopts the curated Schema.org ontology manifest (
@equationalapplications/schema-org-llm-wiki@4.22.0) for Clanker's warm-agent memory system. Seeds the 9-node, 28-edge manifest for cloud characters during sync, and bumps wiki packages to 4.22.0 for triple-keyed edge validation support.Spec: docs/superpowers/specs/2026-07-14-curated-schema-ontology-design.md
Type of Change
Related Issue
Fixes #
Changes Made
@equationalapplications/expo-llm-wikiand@equationalapplications/core-llm-wikito 4.22.0; add@equationalapplications/schema-org-llm-wiki@^4.22.0schemaOrgWarmAgentManifestfor cloud characters during sync when no manifest exists locally or in the cloud bundleTesting
Platforms Tested
Test Steps
schemaOrgWarmAgentManifestis seeded in strict mode