Add notifications field to alert rule management - #96
Merged
Conversation
🧪 Template Spec Check (static — not execution-tested)Grades the template text only: structure + an LLM judge on spec quality. No agent was run and no tools were executed — a pass does not mean the agent works. ✅ All templates passed · 1/1 passed · threshold:
|
| Dimension | Score | Comment |
|---|---|---|
| clarity | 0.85 |
Steps 1–6 are specific and tool-mapped, but step 6's instruction to use 'the outcome of the alert rule creation tool as the email body' is vague about what constitutes a valid email body and lacks guidance on handling malformed or oversized responses. |
| nonContradiction | 0.90 |
Guidelines and instructions are largely aligned; however, the guideline 'Log all actions and decisions' contradicts the absence of a declared logging tool, forcing the agent to either ignore this mandate or improvise. |
| scope | 0.95 |
The agent has a clear termination condition (email notification sent after alert rule creation), though no explicit success/failure criteria are defined for the overall workflow. |
| completeness | 0.70 |
Step 4's 5-second wait is hardcoded with no polling or verification that attachment succeeded before proceeding; step 6 specifies no email content format, required fields, or handling of alert rule creation failures; no timeout or escalation path is defined if any step fails. |
| instructionToolAlignment | 0.80 |
All six instruction steps map to declared tools (search_connections, get_stream, create_stream, attach_stream_asset, wait, create_stream_alert_rule, send_email_notification), but the declared tool 'get_stream' is used only conditionally and the guideline to 'log all actions' has no corresponding tool. |
albert-eqix
approved these changes
Aug 26, 2026
shbhatt4
approved these changes
Aug 26, 2026
jonawong
approved these changes
Aug 26, 2026
imaley
reviewed
Aug 26, 2026
Collaborator
There was a problem hiding this comment.
this tool was renamed to get_stream, can we update it?
xbai-equinix
approved these changes
Aug 26, 2026
…y Schema Updates - Thu Aug 27 01:25:12 UTC 2026 [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
previewandreleasedlists for OnEvent.json/OnSchedule.json are correctreleasedare properly tested and ready for production