use metal_ variables instead of equinix_metal_#85
Open
Conversation
Member
Author
|
I enabled HA and #83 appears to not be an issue. |
16975d8 to
a754089
Compare
equinix_metal_ as a prefix is overly verbose and doesn't follow the practices of other Equinix Terraform modules. Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
b35982a to
a978417
Compare
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
ctreatma
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the equinix_metal_ variable names back to metal_.
metal_ is the current convention: https://github.com/equinix-labs/terraform-equinix-template/blob/main/variables.tf
Previously this PR was focused on the conversion to the Equinix provider, which was merged in #88
The old description follows:
Updates the Terraform provider from the Metal provider, which has been deprecated, to the Equinix provider.
If updating from a previously deployed environment, the following guide should help: https://registry.terraform.io/providers/equinix/equinix/latest/docs/guides/migration_guide_equinix_metal
terraform applybuilds the HA Anthos 1.8.7 environment successfully.