Update to dakota 6.23 - #138
Merged
Merged
Conversation
larsevj
force-pushed
the
bump_boost_dakota
branch
3 times, most recently
from
March 4, 2026 15:45
5510fc1 to
eeeedc5
Compare
larsevj
commented
Mar 4, 2026
| """ | ||
| libs = macros["Dakota_LIBRARIES"] | ||
| libs = [name[2:] if name.startswith("-l") else name for name in libs] | ||
| libs = [name.split("::")[-1] if "::" in name else name for name in libs] |
Contributor
Author
There was a problem hiding this comment.
The only significant change in this file. Apparently some autoformatting.
larsevj
force-pushed
the
bump_boost_dakota
branch
from
March 5, 2026 08:25
ed3eccf to
9ceb216
Compare
There was a problem hiding this comment.
Pull request overview
Updates the Dakota dependency used by Carolina’s build and packaging tooling, while removing now-unnecessary downstream patches and adjusting the build/link process for newer Dakota exports.
Changes:
- Bump Dakota from 6.21.0 to 6.23.0 across build scripts and CI workflows.
- Remove application of several Dakota patch files that are no longer needed with Dakota 6.23.
- Update the Python extension build to handle CMake-style namespaced library entries in Dakota’s exported macros.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Adjusts parsing of Dakota-exported libs (including CMake namespaces) and refactors string/style formatting. |
| script/build_boost_dakota.sh | Bumps Dakota version and removes now-unneeded patch steps for local dependency builds. |
| dakota_manylinux_install_files/build_deps_gha.sh | Removes patch applications and forces install libdir to lib for consistent artifact layout. |
| dakota_manylinux_install_files/build_deps_docker.sh | Same patch removals + libdir setting; fixes a log message typo. |
| README.md | Updates stated supported Python versions. |
| .github/workflows/bundle_with_dakota_macos.yml | Removes patch steps during macOS dependency build. |
| .github/workflows/bundle_with_dakota_caller.yml | Updates the default Dakota version used by CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
larsevj
marked this pull request as ready for review
March 5, 2026 09:49
larsevj
force-pushed
the
bump_boost_dakota
branch
from
March 5, 2026 10:57
9ceb216 to
11957e7
Compare
larsevj
force-pushed
the
bump_boost_dakota
branch
from
March 5, 2026 11:16
11957e7 to
71580d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried updating boost, but that caused some issues, and could not see any relevant changes for dakota so i dropped it.
Also removes some unneded patches that has been solved in latest dakota version.