Add generic table and populate with reactionsteps from tocomo - #512
Merged
Conversation
haralde
force-pushed
the
tocomo-steps
branch
2 times, most recently
from
October 6, 2025 14:48
babc721 to
6492e01
Compare
lars-petter-hauge
left a comment
lars-petter-hauge
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this PR.
I added some comments, more questions really. Very nice that this is added!
Comment on lines
-100
to
-104
| class SimulationResults(BaseModel): | ||
| results: Results | ||
| analysis: Optional[Analysis] = None | ||
| chart_data: ChartData | ||
| table_data: Optional[Any] = None |
Collaborator
There was a problem hiding this comment.
Is this also unused? Perhaps it's only called Runresponse and the likes..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds reactionsteps for tocomo.
A new panel type showing tabular data is added, data for this panel type will be formatted in backend.