Remove Co2 from final concs - #571
Merged
Merged
Conversation
UsamaEquinorAFK
requested review from
Copilot,
kvashchuka and
lars-petter-hauge
November 12, 2025 14:18
There was a problem hiding this comment.
Pull Request Overview
This PR removes CO2 from the final concentrations returned by the pHPitz model adapter, aligning it with the established pattern used in other model adapters like Gibbs Minimization Model.
- Filters out CO2 component from final_concentrations dictionary
- Improves code readability by reformatting the dictionary comprehension to multiple lines
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.