Facilitate adapter version - #581
Closed
lars-petter-hauge wants to merge 2 commits into
Closed
Conversation
|
|
||
| return ( | ||
| <> | ||
| <Typography>{simulationResults.modelVersion}</Typography> |
Collaborator
Author
There was a problem hiding this comment.
not ment to be like this, was just to showcase that it works
Collaborator
Author
|
Happy to see the tests are failing (with sensible error) without any migration setup! |
lars-petter-hauge
force-pushed
the
add_version
branch
5 times, most recently
from
November 25, 2025 14:53
b552fce to
834b6b9
Compare
lars-petter-hauge
force-pushed
the
add_version
branch
3 times, most recently
from
February 12, 2026 14:07
4731fb4 to
ae5df6b
Compare
lars-petter-hauge
force-pushed
the
add_version
branch
2 times, most recently
from
February 12, 2026 14:32
5547535 to
5264587
Compare
lars-petter-hauge
force-pushed
the
add_version
branch
from
February 12, 2026 14:36
5264587 to
4e0e330
Compare
| concentrations=result.concentrations, | ||
| panels=result.panels, | ||
| panels=[ | ||
| TypeAdapter(AnyPanel).validate_python(panel) |
Collaborator
Author
There was a problem hiding this comment.
unsure if this is necessary, this is a case of "it was already in place, so I copied it"
Collaborator
Author
|
I am closing this one. We will likely do it, but codebase has moved quite a bit and some assumptions might not hold that much longer (making this pr simpler than in its current form) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves: #488
We don't know the version until the model has run (as it can change dynamically), hence we put it on the SimulationResult. Slight awkward that e.g. model_id and model_version are attached to two different pydantic objects (only mapped through Simulation_id), but that's perhaps something we need to live with.