Refactor query statuses - #587
Merged
Merged
Conversation
| @@ -1,25 +1,20 @@ | |||
| import { SimulationStatus } from "@/hooks/useSimulationQueriesResult"; | |||
Collaborator
There was a problem hiding this comment.
we were considering having this in some dto instead.. It doesn't feel good importing from a hook.. will do later
|
|
||
| if (result.data) { | ||
| (data[result.data.experiment.name] ??= []).push(result.data.result); | ||
| statuses.push({ |
Collaborator
There was a problem hiding this comment.
having this separation does mean that technically the status will be populated in two different objects, as SimulationResults already has a status. This part is coming all the way from the backend, so we leave it as is.
The reason for separating them was to avoid having SimulationsResults with empty concentrations, and not having to repack things on the outside.
I kinda think it's a bit off to have the SimulationsResults have the status as part of it. Kinda; why make a SimulationResults object before there are any results?
lars-petter-hauge
approved these changes
Nov 26, 2025
Collaborator
|
just need some test fixing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.