Add useSimulationHistory and History component - #612
Merged
Conversation
pinkwah
force-pushed
the
get-results
branch
2 times, most recently
from
December 15, 2025 09:31
50accb6 to
c58ea82
Compare
haralde
reviewed
Dec 16, 2025
haralde
left a comment
haralde
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and works as expected. One comment though which can be fixed in another PR:
I think I would prefer the history section to not be a popup that disappears after selecting an entry. And also keep the scrolling "fixed", or do something smart to keep the focus on the results. As of now if I want to quickly compare results from several runs I need to every time click twice and scroll to the bottom to view the results.
haralde
approved these changes
Dec 16, 2025
pinkwah
force-pushed
the
get-results
branch
2 times, most recently
from
December 17, 2025 11:04
346eca2 to
c2a9cf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.