Restrict HTTP methods and headers with CORS - #695
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the backend’s CORS configuration by explicitly allowing only the HTTP methods and request headers the frontend uses, and by adding a startup-time guard against an invalid credentialed CORS configuration (allow_credentials=True with allow_origins=["*"]).
Changes:
- Add fail-fast validation that raises if
"*"is present in the configured CORS origins while credentials are enabled. - Restrict CORS allowed methods to
GET,POST,PUT,DELETE,OPTIONS(instead of"*"). - Restrict CORS allowed headers to
AuthorizationandContent-Type(instead of"*").
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
haralde
approved these changes
May 12, 2026
Collaborator
|
don't see a reason for not adding this, gogogo :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict allowed CORS methods to:
GET,POST,PUT,DELETE,OPTIONSRestrict allowed CORS headers to:
Authorization,Content-TypeAdd fail-fast validation that raises on origin
"*"whenallow_credentialsis true, as this will fail silently in the browser if misconfigured