Fix dockerfile - #706
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the backend Dockerfiles to improve copy semantics for the local build and to set UV_NO_CACHE=1 in both the local and production images.
Changes:
- Update
backend/Dockerfile.localto copypyproject.toml/uv.lockand the repo contents using./and.relative toWORKDIR. - Add
ENV UV_NO_CACHE=1to bothbackend/Dockerfile.localandbackend/Dockerfile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| backend/Dockerfile.local | Adjusts COPY destinations relative to WORKDIR and adds UV_NO_CACHE. |
| backend/Dockerfile | Adds UV_NO_CACHE environment variable. |
Comments suppressed due to low confidence (1)
backend/Dockerfile:23
EXPOSE 8001does not match the port the container actually listens on:/app/entrypointstarts uvicorn with--port 8000, andradixconfig.yamlalso targets port 8000. This mismatch can break routing/health checks. Align these by exposing 8000 (or changing the entrypoint/app port to 8001) consistently across the production Dockerfile and deployment config.
EXPOSE 8001
ENV UV_NO_CACHE=1
ENV PYTHONDONTWRITEBYTECODE=1
ENV PYTHONUNBUFFERED=1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.