Remove N2O from Gibbs Model - #714
Merged
Merged
Conversation
Collaborator
|
Hi @Sviatose! Could you write down some reasoning behind this decision? |
Collaborator
|
I would also like to the see the commit message same as the title of this PR:) It is very helpful for future us if the git history is clear |
Collaborator
Author
|
When I test H2O 100 ppm H2S 100 ppm SO2 100 ppm NO 100 ppm the model produces a lot of N2O which I believe is not correct and instead ammonia should form. I think we should do experiments and confirm which products are formed to be sure, but I dont think we can form N2O in so high amounts |
kvashchuka
approved these changes
Jun 9, 2026
kvashchuka
force-pushed
the
removeN2OGibbs
branch
from
June 9, 2026 12:36
9a98b2a to
666394e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.