Passthrough invalid components - #778
Merged
Merged
Conversation
lars-petter-hauge
force-pushed
the
pass_through_concentrations
branch
from
June 24, 2026 09:43
ae89c3f to
ef9a364
Compare
Whenever models where chained, only the components that would be accepted by a model would be included. Say H2O was an output in model A, but not a valid component in model B. Then the component would be ignored as of Model B. This is especially important whenever we will get another section in the chain, as otherwise a model in between could end up removing components for models later.
lars-petter-hauge
force-pushed
the
pass_through_concentrations
branch
from
June 25, 2026 06:25
ef9a364 to
174cab0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever models where chained, only the components that would be
accepted by a model would be included. Say H2O was an output in model A,
but not a valid component in model B. Then the component would be
ignored as of Model B.
This is especially important whenever we will get another section in the
chain, as otherwise a model in between could end up removing components
for models later.