-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor/service now urgency level unable #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
aslakihle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to bump version, or just let this be part of the next release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the urgency level mapping for ServiceNow feedback submissions by downgrading both UNABLE and IMPEDES urgency options to map to ServiceNowUrgency.NORMAL instead of their previous higher severity levels.
Key Changes:
- Modified urgency mapping so that
UrgencyOption.UNABLEreturnsServiceNowUrgency.NORMALinstead ofCRITICAL - Modified urgency mapping so that
UrgencyOption.IMPEDESreturnsServiceNowUrgency.NORMALinstead ofMODERATE - Bumped package version from 10.8.0 to 10.8.1
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/organisms/TopBar/Resources/Feedback/Feedback.utils.ts | Updated getUrgencyNumber function to map both UNABLE and IMPEDES urgency options to NORMAL severity level |
| package.json | Incremented patch version to 10.8.1 to reflect the urgency mapping changes |
Comments suppressed due to low confidence (1)
src/organisms/TopBar/Resources/Feedback/Feedback.utils.ts:54
- The getUrgencyNumber function lacks test coverage. Since the test file Feedback.utils.test.ts already contains tests for other utility functions like getSeverityEmoji, consider adding tests to verify the urgency mapping behavior, especially given this change in mapping logic.
export const getUrgencyNumber = (urgency: UrgencyOption) => {
switch (urgency) {
case UrgencyOption.UNABLE:
return ServiceNowUrgency.NORMAL;
case UrgencyOption.IMPEDES:
return ServiceNowUrgency.NORMAL;
case UrgencyOption.NO_IMPACT:
return ServiceNowUrgency.NORMAL;
}
};
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request makes a small but important change to how urgency levels are mapped in the
readUploadedFileAsTextutility. Now, bothUNABLEandIMPEDESurgency options are mapped toServiceNowUrgency.NORMALinstead ofCRITICALandMODERATE, respectively.getUrgencyNumberso that bothUrgencyOption.UNABLEandUrgencyOption.IMPEDESnow returnServiceNowUrgency.NORMALinstead of their previous higher urgency levels. (src/organisms/TopBar/Resources/Feedback/Feedback.utils.ts)