Skip to content

Conversation

@benjamin-lyon
Copy link
Contributor

@benjamin-lyon benjamin-lyon commented Dec 17, 2025

Azure DevOps links

User story


  • Needs to be tested locally by reviewer

Description

  • This PR changes the single select component to prevent the clear button from being rendered when the component is disabled.

Copilot AI review requested due to automatic review settings December 17, 2025 13:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

The changes include adding a disabled state test for SingleSelect and preventing the clear button from showing when the component is disabled.

Key changes:

  • Updated clear button visibility logic to hide it when the component is disabled
  • Added a new test story DisabledSingleSelect to verify the disabled state

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/molecules/Select/SingleSelect/SingleSelect.stories.tsx Adds imports for StoryObj and expect, and creates a new DisabledSingleSelect story with a play function to test disabled behavior
src/molecules/Select/SearchBar.tsx Adds aria-disabled attribute to the Container element and updates the clear button conditional to respect disabled state

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 99.17% (🎯 100%) 16442 / 16578
🔵 Statements 99.17% (🎯 100%) 16442 / 16578
🔵 Functions 99.07% (🎯 100%) 1178 / 1189
🔵 Branches 99.31% (🎯 100%) 4037 / 4065
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/molecules/Select/SearchBar.tsx 99.44% 98.27% 75% 99.44%
Generated in workflow #2016 for commit b023858 by the Vitest Coverage Report Action

@benjamin-lyon benjamin-lyon changed the title Fix/select-aria-disabled-attribute Fix/hide-singleselect-clear-on-disabled Dec 17, 2025
@equinor equinor deleted a comment from Copilot AI Dec 17, 2025
@equinor equinor deleted a comment from Copilot AI Dec 17, 2025
Copilot AI review requested due to automatic review settings December 17, 2025 13:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@benjamin-lyon benjamin-lyon marked this pull request as ready for review December 17, 2025 14:07
@benjamin-lyon benjamin-lyon requested a review from a team as a code owner December 17, 2025 14:07
Copilot AI review requested due to automatic review settings December 17, 2025 14:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants