-
Notifications
You must be signed in to change notification settings - Fork 2
Fix/hide-singleselect-clear-on-disabled #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
The changes include adding a disabled state test for SingleSelect and preventing the clear button from showing when the component is disabled.
Key changes:
- Updated clear button visibility logic to hide it when the component is disabled
- Added a new test story
DisabledSingleSelectto verify the disabled state
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/molecules/Select/SingleSelect/SingleSelect.stories.tsx | Adds imports for StoryObj and expect, and creates a new DisabledSingleSelect story with a play function to test disabled behavior |
| src/molecules/Select/SearchBar.tsx | Adds aria-disabled attribute to the Container element and updates the clear button conditional to respect disabled state |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Azure DevOps links
User story
Description