Skip to content

Move verify_migrations to pull_request-triggered stage - #42

Merged
aeshub merged 2 commits into
equinor:mainfrom
aeshub:move-verify-to-stage-one
Apr 28, 2026
Merged

Move verify_migrations to pull_request-triggered stage#42
aeshub merged 2 commits into
equinor:mainfrom
aeshub:move-verify-to-stage-one

Conversation

@aeshub

@aeshub aeshub commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Move verify_migrations job from migration_actions.yml (workflow_run stage) to migration_checks.yml (pull_request stage)
  • Remove the now-unused update_success_message env var from migration_actions.yml

Why

Jobs in workflow_run-triggered workflows run against the default branch SHA, not the PR head SHA. This means verify_migrations was executing correctly but its status was not reported as a PR check, making it impossible to use as a required status check in branch protection.

By moving it to the pull_request-triggered stage, the job runs in the PR context and its status appears in the PR checks tab.

Consumer repo changes

The reusable migration_checks.yml now requires pull-requests: read and issues: read permissions (for peter-evans/find-comment). The following PRs add these permissions:

@aeshub
aeshub merged commit 3c3dfb3 into equinor:main Apr 28, 2026
2 checks passed
@aeshub
aeshub deleted the move-verify-to-stage-one branch April 28, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant