Move verify_migrations to pull_request-triggered stage - #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_migrationsjob frommigration_actions.yml(workflow_run stage) tomigration_checks.yml(pull_request stage)update_success_messageenv var frommigration_actions.ymlWhy
Jobs in
workflow_run-triggered workflows run against the default branch SHA, not the PR head SHA. This meansverify_migrationswas executing correctly but its status was not reported as a PR check, making it impossible to use as a required status check in branch protection.By moving it to the
pull_request-triggered stage, the job runs in the PR context and its status appears in the PR checks tab.Consumer repo changes
The reusable
migration_checks.ymlnow requirespull-requests: readandissues: readpermissions (forpeter-evans/find-comment). The following PRs add these permissions: