Add runs_on input to reusable deploy workflows - #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
runs_oninput to the reusable deploy workflows so consumers can pick a self-hosted runner (or any label other thanubuntu-latest) for the docker build / image copy jobs.Affected workflows:
build_and_publish_docker_image_to_container_registry.yml— build job.deploy_to_development.yml— plumbsruns_ondown to the publish call.deploy_to_staging.yml— plumbsruns_ondown to the publish call.promote_to_production.yml— image-copy job.Default remains
ubuntu-latest. Backward compatible.Motivation
sara-anonymizerbuilds a ~10 GB image (torch + torchvision + deeplab weights) that runs out of disk on GitHub-hostedubuntu-latestrunners (14 GB total). Its pre-migration workflow usedruns-on: ubuntu— an Equinor self-hosted runner label with more disk. Since #91 migrated the publish step into the armada reusable, sara-anonymizer's dev deploys have been failing with:With this input, sara-anonymizer (and any other repo with the same issue) can pass
runs_on: ubuntuin its deploy workflow to route the build back to the self-hosted runner.Notes
update_kubernetes_deployment.yml) still runs onubuntu-latest— it does a lightweight git checkout/sed/push and never needs the extra disk.runs_on: ubuntu.