fix: demo app build - #4283
Merged
Merged
Conversation
…ckage.json and pnpm-lock.yaml
Hjaf
requested review from
Chibuzor-Nwemambu,
millus,
pomfrida,
torleifhalseth and
vnys
as code owners
December 4, 2025 11:05
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Next.js and Babel dependencies to their latest patch versions and fixes the Docker build process by ensuring workspace dependencies are built in the correct order. The changes primarily address dependency maintenance and build reliability improvements.
Key changes:
- Updated Next.js-related packages (
eslint-config-next,@next/mdx) from16.0.0to16.0.7 - Updated Babel core packages to version
7.28.5for improved consistency - Enhanced Dockerfile to build workspace dependencies (
@equinor/eds-utils,@equinor/eds-icons,@equinor/eds-core-react) before building the demo app
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
apps/eds-demo/package.json |
Updated @next/mdx and eslint-config-next to version 16.0.7 |
apps/eds-color-palette-generator/package.json |
Updated eslint-config-next to version 16.0.7 |
DockerfileEdsDemo |
Added build steps for @equinor/eds-utils, @equinor/eds-icons, and @equinor/eds-core-react to fix build dependency order |
.gitignore |
Added .pnpm-store to ignore pnpm's local store directory |
pnpm-lock.yaml |
Updated lockfile to reflect dependency version changes with Babel packages consolidated to 7.28.5 and Next.js packages to 16.0.7 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4 tasks
eddiman
pushed a commit
that referenced
this pull request
Jan 12, 2026
* fix: add .pnpm-store to .gitignore * fix: update Dockerfile to build additional workspace dependencies for EDS * fix: update eslint-config-next and @next/mdx versions to 16.0.7 in package.json and pnpm-lock.yaml * Remove accidental inclusion of file in commit ec3198a. * Update package.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates several dependencies to their latest patch versions and improves the build process in the Dockerfile. The most significant changes include updating Next.js-related and Babel dependencies, as well as ensuring the correct build order for workspace packages.
Dependency updates:
eslint-config-next,@next/mdx, and@next/eslint-plugin-nextfrom version16.0.0to16.0.7inapps/eds-demo/package.json,apps/eds-color-palette-generator/package.json, andpnpm-lock.yamlto ensure compatibility and pull in the latest fixes. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]@babel/types,@babel/parser, and@babel/helper-validator-identifier) to version7.28.5throughoutpnpm-lock.yamlfor improved stability and bug fixes. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Build process improvements:
@equinor/eds-utils,@equinor/eds-icons,@equinor/eds-core-react) in the build order before buildingeds-demo, ensuring dependencies are built in the correct sequence.Other dependency consistency:
pnpm-lock.yamlfor improved linting reliability.These changes help keep the project up-to-date with the latest dependency patches, improve build reliability, and maintain compatibility across the workspace.