fix: only run CDN purge for production storybook - #4321
Merged
Conversation
pomfrida
requested review from
Chibuzor-Nwemambu,
millus,
torleifhalseth and
vnys
as code owners
December 9, 2025 12:33
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where environment-scoped secrets and variables were not accessible in the _purge_cdn.yaml reusable workflow. The fix moves environment variable declarations from the workflow level to the job level, which is necessary because the environment context is specified at the job level. In GitHub Actions, environment-scoped secrets and vars are only accessible within jobs that declare the environment, not at the workflow level.
Key Changes
- Moved
envdeclarations from workflow level to job level to ensure environment-scoped secrets and variables are accessible - Removed obsolete comment explaining the previous workaround
pomfrida
had a problem deploying
to
development
December 9, 2025 12:40 — with
GitHub Actions
Failure
Collaborator
Author
|
Tested here and it now skips purge CDN on env=dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4322