docs: add ADR 0011 — adopt the Tokens Studio platform token pipeline - #5195
docs: add ADR 0011 — adopt the Tokens Studio platform token pipeline#5195pomfrida wants to merge 3 commits into
Conversation
|
@claude review |
|
Claude finished @pomfrida's task in 1m 29s —— View job Review: ADR 0011 — Tokens Studio platform pipeline
This is a well-structured, accurate ADR. I cross-checked every substantive claim against the actual sources in the repo and they hold up. No blocking issues — a few minor notes below. Accuracy check ✅Verified the "Decision" section against the real implementation:
All four Minor notes (non-blocking)
Nice work — the doc is precise and the CI/OIDC/backup rationale is captured at exactly the right altitude for an ADR. |
…decide publish boundary - Renumber 0009 → 0014 (0009 taken on main, 0010–0013 claimed by open PRs) - Slim decision point 1 to a reference to ADR-0011 (#5195) instead of restating it - Mark the @layer wrap as decided-but-pending and note the ADR-0010 amendment (#5199) - New decision point 7: publish boundary — semantic layer is the contract, scheme/primitive names are resolution plumbing, ts/primitives and ts/color-scheme are reference output - Rewrite the collision consequence/confirmation around the intra-export flattening collision (border.focus vs border-focus, self-referential var()) and record that verification must run on built CSS, not platform resolution - Soften the drift claim: structure and source values, with the oklch-vs-hex gamut exception called out - Smaller: src/tokens/raw/ (not <alias>), mode-as-file rationale vs the RN mode-as-key sketch, Swift/Compose format note (#5123), reference-chain lint in Confirmation, textStyle follow-up
Chibuzor-Nwemambu
left a comment
There was a problem hiding this comment.
Looking Good 🎉
I see the description states the status as Proposed, but the doc actually has it as Accepted, which was deliberately added in one of the commits.
Just a quick update to the description to match the current status, is needed. Otherwise everything else seems fine 💪🏾.
Closes #5197
Summary
Records the architecture decision behind the Tokens Studio pipeline work merged over the last weeks (#5151, #5153, #5155, #5160, #5166, #5175, #5176): the platform is the source of truth for the reworked tokens, updates flow through a release-triggered, OIDC-authenticated CI pipeline that lands platform exports as PRs, and the hourly orphan-branch backup (
tokens-studio-backup) compensates for the platform having no undo.ADR-0008 (TS codegen) documents one slice of this pipeline; this ADR is the overarching decision it builds on, and gives future token ADRs a common anchor.
Part of #5108.
Notes